Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hande more strikethrough cases #145

Merged
merged 8 commits into from
Jun 30, 2021
Merged

hande more strikethrough cases #145

merged 8 commits into from
Jun 30, 2021

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Jun 30, 2021

Fixes #144

@stdavis stdavis requested a review from steveoh June 30, 2021 17:36
@steveoh
Copy link
Member

steveoh commented Jun 30, 2021

It looks like google cloud has a different dependency on flask than what you added.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #145 (75555ad) into main (ae5cb70) will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   86.65%   86.65%           
=======================================
  Files           2        2           
  Lines         427      427           
  Branches       72       72           
=======================================
  Hits          370      370           
  Misses         51       51           
  Partials        6        6           
Impacted Files Coverage Δ
src/conductor/checks.py 90.60% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3203a39...75555ad. Read the comment docs.

@stdavis stdavis merged commit 3fdc435 into main Jun 30, 2021
@stdavis stdavis deleted the strikeout branch June 30, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conductor should ignore action items that are ~strikethrough~
2 participants