AG-208: Feature enrichment for XAResourceWrapper #69
Conversation
graben
force-pushed
the
AG-208
branch
4 times, most recently
from
4bfc4b4
to
9ce9343
Compare
|
@barreiro : Did find time to review, yet? |
|
thanks @graben. I'm writing a couple more test cases and then I'll be able to merge this PR. |
graben
force-pushed
the
AG-208
branch
3 times, most recently
from
407049b
to
20b48d0
Compare
agroal-narayana/src/main/java/io/agroal/narayana/LocalXAResource.java
Outdated
Show resolved
Hide resolved
agroal-narayana/src/main/java/io/agroal/narayana/NarayanaTransactionIntegration.java
Show resolved
Hide resolved
agroal-narayana/src/main/java/io/agroal/narayana/NarayanaTransactionIntegration.java
Outdated
Show resolved
Hide resolved
agroal-narayana/src/main/java/io/agroal/narayana/FirstResourceBaseXAResource.java
Show resolved
Hide resolved
agroal-narayana/src/main/java/io/agroal/narayana/ConnectableLocalXAResource.java
Outdated
Show resolved
Hide resolved
|
@barreiro : Feedback added to PR |
graben
changed the title
|
awesome !! thanks @graben |
|
Hi @barreiro, I'm just thinking about CommitMarkableResource wouldn't really work well with Spring-Boot as DataSource isn't being bind to JNDI. I think I will work on another improvement for this. |
|
@graben that would be an improvement to either Narayana or Spring-Boot, no ?? The By the way, I'm not sure Quarkus has everything need for CMR either. |
|
@barreiro : It'll be an improvement to the Spring-Boot starter only. I'm just coding a bit in a WIP branch AG-xxx I'll submit PR once ready. By the way, further enhance of integration of Narayana to Spring-Boot is also on the way snowdrop/narayana-spring-boot#107 |
|
@graben thanks for letting me know. I have left some comments. |
@barreiro : Could you plz review?