Add lastResourceOptimisationInterfaceClassName and commitMarkableResourceJNDINames to JTAEnvironmentBean for better integration with agroal #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graben
changed the title
graben
changed the title
barreiro
suggested changes
Aug 4, 2023
...e/src/main/java/me/snowdrop/boot/narayana/core/properties/NarayanaPropertiesInitializer.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/me/snowdrop/boot/narayana/core/properties/NarayanaPropertiesInitializer.java
Show resolved
Hide resolved
…urceJNDINames to JTAEnvironmentBean for better integration with agroal
graben
changed the title
|
@Sgitario : Could you plz review and merge |
|
@barreiro can you have a final review on this pull request? Thanks! |
|
@Sgitario : Ready to merge and probably do a first release of 3.0? |
|
Merged. |
|
@Sgitario : Well, last time @jacobdotcosta was asked for a release, nothing happens. Anyone else able to do releases? |
No that I'm aware of. @jacobdotcosta is on PTO until 28 Aug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement based on feedback from agroal/agroal#69. Implementation analog to WildFly JTAEnvironmentBeanService.java#L61