Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trio 0.15 warnings #106

Merged
merged 11 commits into from
May 21, 2020
Merged

Fix trio 0.15 warnings #106

merged 11 commits into from
May 21, 2020

Conversation

smurfix
Copy link
Collaborator

@smurfix smurfix commented May 19, 2020

No description provided.

@njsmith
Copy link
Collaborator

njsmith commented May 19, 2020

Diff looks plausible to me. You have test failures though, and GitHub isn't letting me see the logs on my phone, so maybe everything is broken, I dunno :-)

I'm curious why anyio needs to subclass trio.Condition instead of just using it.

@agronholm
Copy link
Owner

I'm curious why anyio needs to subclass trio.Condition instead of just using it.

Because the notify and notify_all methods are coroutine methods in anyio and regular methods in trio.

@agronholm
Copy link
Owner

Diff looks plausible to me. You have test failures though, and GitHub isn't letting me see the logs on my phone, so maybe everything is broken, I dunno :-)

./anyio/_backends/_trio.py:250:1: W293 blank line contains whitespace

@@ -2,11 +2,11 @@
from types import TracebackType
from typing import Callable, Optional, List, Type, Union

import trio.hazmat
import trio.lowlevel
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module does not exist in trio before v0.15. It would be better to use a conditional import for now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. (For some values of "done" …)

@smurfix
Copy link
Collaborator Author

smurfix commented May 19, 2020

OK, the Lock argument was missing. No longer testing against Py3.5 with Trio 0.15 should probably be fixed by somebody more familiar with the test setup.

@smurfix
Copy link
Collaborator Author

smurfix commented May 19, 2020

/opt/hostedtoolcache/Python/3.8.2/x64/lib/python3.8/site-packages/curio/pytest_plugin.py:60: PytestDeprecationWarning: direct construction of Function has been deprecated, please use Function.from_parent

Not my problem either, I'm afraid …

Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

anyio/_backends/_trio.py Outdated Show resolved Hide resolved
anyio/_backends/_trio.py Outdated Show resolved Hide resolved
@pquentin
Copy link

Trio 0.15.0 no longer supports Python 3.5, what is AnyIO's policy here?

@agronholm
Copy link
Owner

AnyIO 1.x still supports py3.5 but AnyIO 2.0 (in development) has dropped support. I will look at modifying the test suite to skip trio testing on py3.5.

@agronholm agronholm merged commit 7565b7a into agronholm:master May 21, 2020
@agronholm
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants