-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate models got wrong types #67
Comments
the problem also refused me. |
I've just raised a pull request that I think fixes this issue: #75 |
agronholm
pushed a commit
that referenced
this issue
Sep 9, 2018
* Import vendor-specific types when generic types cannot be used. If a vendor-specific type cannot be adapted to a generic sqlalchemy then import the vendor-specific type rather than the generic type. Some vendor-specific types have different constructors. E.g., MySQL INTEGER, which takes an optional display width. * Bugfix for mysql TINYTEXT, MEDIUMTEXT, and LONGTEXT. Don't adapt types further if they cannot be compiled. Fixes #67.
There's a new release out which fixes this. |
Havoc24k
pushed a commit
to 7Linternational/sqlacodegen
that referenced
this issue
Sep 12, 2018
…nholm#75) * Import vendor-specific types when generic types cannot be used. If a vendor-specific type cannot be adapted to a generic sqlalchemy then import the vendor-specific type rather than the generic type. Some vendor-specific types have different constructors. E.g., MySQL INTEGER, which takes an optional display width. * Bugfix for mysql TINYTEXT, MEDIUMTEXT, and LONGTEXT. Don't adapt types further if they cannot be compiled. Fixes agronholm#67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sqlalchemy: 1.2.8
sqlacodegen: 2.0.0
Backend: MySQL 5.6
Table:
When generate models, the types used in the model are
INTEGER
instead ofInteger
.results in the columns are:
This will raise error as the
INTEGER
orBIGINT
takes no params:I have to reverted
sqlacodgen
to v1.1.6 to make it work again.The text was updated successfully, but these errors were encountered: