Skip to content

Commit

Permalink
Remove bad assert in TxBuffer::mark_as_acked()
Browse files Browse the repository at this point in the history
It is not true that highest_offset >= offset+len, because we unmark ranges
that were sent but need to be retransmitted (b/c lost.) If this happens and
then an ack comes in for the range, that is ok.

fixes mozilla#352
  • Loading branch information
Andy Grover committed Dec 14, 2019
1 parent 15b2683 commit 42bc617
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions neqo-transport/src/send_stream.rs
Expand Up @@ -335,8 +335,6 @@ impl TxBuffer {
}

pub fn mark_as_acked(&mut self, offset: u64, len: usize) {
assert!(self.ranges.highest_offset() >= offset + len as u64);

self.ranges.mark_range(offset, len, RangeState::Acked);

// We can drop contig acked range from the buffer
Expand Down

0 comments on commit 42bc617

Please sign in to comment.