Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in [@ neqo_transport::send_stream::TxBuffer::mark_as_acked] #352

Closed
agrover opened this issue Dec 13, 2019 · 0 comments · Fixed by #353
Closed

Crash in [@ neqo_transport::send_stream::TxBuffer::mark_as_acked] #352

agrover opened this issue Dec 13, 2019 · 0 comments · Fixed by #353
Assignees
@agrover

Comments

@agrover
Copy link
Contributor

agrover commented Dec 13, 2019

FF bug
@agrover agrover self-assigned this Dec 13, 2019
agrover pushed a commit to agrover/neqo that referenced this issue Dec 14, 2019
Remove bad assert in TxBuffer::mark_as_acked()
bbeb71a 
It is not true that highest_offset >= offset+len, because we unmark ranges
that were sent but need to be retransmitted (b/c lost.) If this happens and
then an ack comes in for the range, that is ok.

fixes mozilla#352
@agrover agrover mentioned this issue Dec 14, 2019
Merged
agrover pushed a commit to agrover/neqo that referenced this issue Dec 14, 2019
Remove bad assert in TxBuffer::mark_as_acked()
42bc617 
It is not true that highest_offset >= offset+len, because we unmark ranges
that were sent but need to be retransmitted (b/c lost.) If this happens and
then an ack comes in for the range, that is ok.

fixes mozilla#352
agrover pushed a commit to agrover/neqo that referenced this issue Dec 16, 2019
Remove bad assert in TxBuffer::mark_as_acked()
bb21582 
It is not true that highest_offset >= offset+len, because we unmark ranges
that were sent but need to be retransmitted (b/c lost.) If this happens and
then an ack comes in for the range, that is ok.

fixes mozilla#352
agrover pushed a commit to agrover/neqo that referenced this issue Dec 17, 2019
Remove bad assert in TxBuffer::mark_as_acked()
9f237d5 
It is not true that highest_offset >= offset+len, because we unmark ranges
that were sent but need to be retransmitted (b/c lost.) If this happens and
then an ack comes in for the range, that is ok.

fixes mozilla#352
@mergify mergify bot closed this as completed in #353 Dec 17, 2019
mergify bot pushed a commit that referenced this issue Dec 17, 2019
@mergify
Remove bad assert in TxBuffer::mark_as_acked()
104f4fc 
It is not true that highest_offset >= offset+len, because we unmark ranges
that were sent but need to be retransmitted (b/c lost.) If this happens and
then an ack comes in for the range, that is ok.

fixes #352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agrover agrover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove bad assert in TxBuffer::mark_as_acked() agrover/neqo
1 participant
@agrover