Use new REST client feature to get better simulation result object #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses the new REST client feature from algorand#5253 to allow the client to get msgpack simulation responses. With this, the client can decode to the more precise
v2.PreEncodedSimulateResponse
instead ofmodel.SimulateResponse
.The only real difference between the two is that
model.SimulateResponse
usesmap[string]interface{}
to represent transactions. This is actually a minor problem, since our JSON decoder will decode large integers as float64, and this could make some responses look strange whengoal clerk simulate
re-encodes the JSON response. For example, this response adds.0
after integers in the signed transaction:Test Plan
Note, I'm having issues running the new test in
test/e2e-go/restAPI/restClient_test.go
locally, since algod . I think this may be because it's running an older cached version from my machine