Algod: Minor refactoring REST client submitForm from go-sdk PR #335

[ahangsu]

Summary

The motivation of this PR is that, we want to allow for algod to simulate with option of unlimit-log: see #5230.

We need to send transaction with auxiliary query parameters. The current implementation in restClient disallowed us for such feasibility, while algorand/go-algorand-sdk#335 contain relevant modification, and this PR mimic the changes, by separating request into params and body.

We expect to use this for simulation, where /v2/transactions/simulate has query parameter unlimit-log: bool, with raw body of txn(-group). The simulation request body resembles the one in compilation, where /v2/teal/compile has query parameter sourcemap: bool and raw body of program source bytes.

Test Plan

Implement Compile with sourcemap option, and check existence of sourcemap field, which can be controlled by request option Sourcemap *bool.

[codecov]

Codecov Report

Merging #5253 (e788b1d) into master (7703bc4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5253      +/-   ##
==========================================
- Coverage   53.76%   53.74%   -0.02%     
==========================================
  Files         450      450              
  Lines       56184    56184              
==========================================
- Hits        30206    30195      -11     
- Misses      23628    23639      +11     
  Partials     2350     2350              

Impacted Files	Coverage Δ
data/transactions/logic/sourcemap.go	100.00% <ø> (ø)
libgoal/teal.go	0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jasonpaulos]

Generally looks good. This is a problem I ran into while working on simulate earlier.

In fact I made this follow-up PR to improve simulation response decoding by requesting msgpack responses: ahangsu#1. I can open a PR in go-algorand for that after this one is merged