add CancellationToken #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiredbarb
reviewed
Jan 29, 2018
| @@ -31,7 +32,7 @@ public PlaintextGraphiteFormatter(ushort port):this() | |||
| public ushort Port { get; } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public async Task WriteAsync(Stream stream, ICollection<Datapoint> datapoints) | |||
| public async Task WriteAsync(Stream stream, ICollection<Datapoint> datapoints, CancellationToken cancellationToken = default(CancellationToken)) | |||
| { | |||
| using (var writer = new StreamWriter(stream) {NewLine = "\n"}) | |||
| { | |||
There was a problem hiding this comment.
Konsequenterweise würde ich hier vor den WriteAsync- und Flush-Aufrufen am StreamWriter das CancellationToken prüfen. Oder soll das explizit ignoriert werden?
There was a problem hiding this comment.
StreamWriter.WriteAsync() und StreamWriter.FlushAsync() haben keinen cancellationToken parameter.
There was a problem hiding this comment.
Ich weiß. Deshalb müsste man das selbst prüfen, meinte ich.
wiredbarb
suggested changes
Jan 29, 2018
Graphite/GraphiteClient.cs
Outdated
| /// Send a list of datapoints in up to <see cref="BatchSize"/> batches | ||
| /// </summary> | ||
| /// <param name="datapoints"></param> | ||
| /// <param name="cancellationToken">The token to monitor for cancellation requests. The default value is <see cref="CancellationToken.None"/>.</param> |
There was a problem hiding this comment.
Comment does not match method definition (no default value)
| } | ||
| } | ||
|
|
||
| private async Task SendInternalAsync(ICollection<Datapoint> datapoints) | ||
| private async Task SendInternalAsync(ICollection<Datapoint> datapoints, CancellationToken cancellationToken) | ||
| { | ||
| using (var client = new TcpClient(AddressFamily.InterNetworkV6)) | ||
| { | ||
| client.Client.DualMode = true; | ||
| await client.ConnectAsync(Host, Formatter.Port).ConfigureAwait(false); |
There was a problem hiding this comment.
consider another ThrowIfCancellationRequested here?
check cancellationToken in SendInternalAsync
wiredbarb
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add CancellationToken to all async methods