Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add any programs in Windows 10 #48

Closed
Steve-Bros opened this issue Mar 4, 2020 · 16 comments
Closed

Can't add any programs in Windows 10 #48

Steve-Bros opened this issue Mar 4, 2020 · 16 comments
Assignees
Labels
bug Something isn't working

Comments

@Steve-Bros
Copy link

OS: Windows 10 Home
2 monitors

I decided to install this program very recently, but whenever I try to add an .exe file, this happens.

image

image

This completely defeats the purpose of the program, but I like the concept, so any assistance would be greatly appreciated.

@ahkohd
Copy link
Owner

ahkohd commented Mar 5, 2020

Hi, @Steve-Bros Have you tried adding other programs other than eclipse?

@Steve-Bros
Copy link
Author

I have. I tried to add programs like Microsoft Edge Chromium and Notepad++, along with some portable programs. No .exe file works.

@ahkohd
Copy link
Owner

ahkohd commented Mar 5, 2020

That's wried. Can you do me a favour? Please test it on other windows 10 laptop, It might be a permissions issue.

I tested it here it works so I am not sure how to reproduce your issue.
Please feedback would be nice, Thanks!

@ahkohd ahkohd closed this as completed Mar 5, 2020
@ahkohd ahkohd reopened this Mar 5, 2020
@ahkohd ahkohd assigned ahkohd and unassigned Steve-Bros Mar 5, 2020
@ahkohd
Copy link
Owner

ahkohd commented Mar 12, 2020

@Steve-Bros any update?

@Steve-Bros
Copy link
Author

Sadly, no updates. My main problem is that this is my only computer. I tried reinstalling the software with administrator mode, but still nothing. Sorry.

@ahkohd
Copy link
Owner

ahkohd commented Mar 12, 2020

@Steve-Bros thanks. I will investigate further after I dual-boot my mac with
Windows 10.

@Jack-Chronicle
Copy link

I'm having the same issue here, really hoping it can be fixed easily cause this look super amazing

@ahkohd
Copy link
Owner

ahkohd commented Mar 15, 2020

@Jack-Chronicle @Steve-Bros Thanks a lot for reporting this issue.
Please try v1.0.25 https://github.com/ahkohd/switch-desktop/releases/download/v1.0.25/Switch-Setup-1.0.25.exe

It's funny that I have forgotten why I haven't made this version public yet, but it seems it contains the fix to the reported issue.
Please help me out by testing ASAP so that I can update the link at the homepage.

Thanks!

@DylanAkp
Copy link

Same issue here, already with the v1.0.25

@ahkohd
Copy link
Owner

ahkohd commented Mar 23, 2020

Same issue here, already with the v1.0.25

It worked on the last Windows10 system I tried it on. I wonder what is wrong, I will try and investigate tomorrow as soon as I lay my hands on a Windows10 system.

@ahkohd
Copy link
Owner

ahkohd commented Mar 23, 2020

I think I have found what the issue is.
Screenshot 2020-03-23 at 21 49 32

According to http://mimeapplication.net/x-msdownload it's said that the content-type of a .exe can be one out of application/x-msdownload, application/octet-stream and application/x-msdos-program.

but in the code, I only checked if the content type is application/x-msdownload

image

@ahkohd
Copy link
Owner

ahkohd commented Mar 23, 2020

As a matter of fact, content types related to application/x-msdownload are:

let exeRelatedContentTypes = [
'application/x-msdownload',
'application/bin',
'application/binary',
'application/com',
'application/dos-exe',
'application/exe',
'application/macbinary',
'application/msdos-windows',
'application/octet-stream',
'application/x-com',
'application/x-exe',
'application/x-macbinary',
'application/x-msdos-program',
'application/x-stuffit',
'application/x-tencore',
'application/x-winexe',
'application/x-zip-compressed',
'vms/exe',
];

then the fix will go like this:

if (exeRelatedContentTypes.includes(file.type) && ....

I will make an update before tomorrow night to fix this issue, till then please bear with me.

@ahkohd ahkohd added the bug Something isn't working label Mar 23, 2020
@ahkohd ahkohd closed this as completed in 64efb76 Mar 23, 2020
@ahkohd ahkohd reopened this Mar 23, 2020
@ahkohd
Copy link
Owner

ahkohd commented Mar 23, 2020

@Steve-Bros @Jack-Chronicle @DylanAkp 😉I just fixed the issue. PR #51 ships the fix to the bug.
You can download the update from the home page.

I have tested here, it works, but just to be double sure I need someone else to test it, just to affirm that the fix works. 😁

@DylanAkp
Copy link

Fixed for me, thank you for your work !

@ahkohd
Copy link
Owner

ahkohd commented Mar 25, 2020

Can anyone confirm this before I close this issue?

@DylanAkp
Copy link

DylanAkp commented Mar 25, 2020 via email

@ahkohd ahkohd closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants