Skip to content
This repository has been archived by the owner on Oct 10, 2022. It is now read-only.

Incorrect dependencies #55

Open
TimothyBJacobs opened this issue May 8, 2018 · 8 comments
Open

Incorrect dependencies #55

TimothyBJacobs opened this issue May 8, 2018 · 8 comments

Comments

@TimothyBJacobs
Copy link

See, https://wordpress.slack.com/archives/C02QB2JS7/p1525790289000579

@ahmadawais
Copy link
Owner

I'll need more details then that. 👋

@TimothyBJacobs
Copy link
Author

If you try to run the latest version of Gutenberg with a create-guten-block the styles on the front-end won't load because of the missing wp-blocks dependency.

I also don't believe the other dependencies are necessary either.

@ahmadawais
Copy link
Owner

I'd love for you to create a PR to fix this? Find the template in packages/cgb-scripts/template/ inside this repo.

Looking forward!

TimothyBJacobs added a commit to TimothyBJacobs/create-guten-block that referenced this issue May 9, 2018
These dependencies aren't necessary. The `wp-blocks` style previously held the styles for core blocks, which the built styles do not depend on. It was also removed in the latest Gutenberg version.

The editor dependencies are always enqueued before the editor assets.

 Fixes ahmadawais#55
@TimothyBJacobs
Copy link
Author

Following up

@ahmadawais
Copy link
Owner

@TimothyBJacobs we're (maintainers) all traveling this week. It'll be a few days before I or someone on the team can test the changes and push live for the next release cycle. Google #io18, #MSBuild, and #WP15, etc.

Bear with us! Peace! ✌️

@ajitbohra
Copy link

ajitbohra commented May 19, 2018

@ahmadawais
Copy link
Owner

@ajitbohra thanks for the review I am away due to a family emergency.

@ajitbohra
Copy link

ajitbohra commented May 19, 2018

@ahmadawais no worries thought to drop details/links for reference, take your time to go through it when its feasible for you.

Emergency !!! Hope nothing serious

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants