Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency should to v13 #50

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency should to v13 #50

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Apr 2, 2018 •
edited

This PR contains the following updates:

Package Type Update Change References
should devDependencies major ^11.1.0 -> ^13.0.0 source

Release Notes

shouldjs/should.js

v13.2.3

Compare Source

  • .only.keys throws when no Object.prototype.should

v13.2.2

Compare Source

  • Updates for TS definition

v13.2.1

Compare Source

  • Fix .size to work with should/as-function

v13.2.0

Compare Source

  • Update type adaptors to allow to use Set as iterable everywhere

v13.1.3

Compare Source

  • Fix weird bug in .containDeep when given object is string (see #​157)

v13.1.2

Compare Source

  • Revert default export in TS definition (added in 13.1.0)

v13.1.1

Compare Source

  • Added missing return type for .rejectedWith in typescript definition

v13.1.0

Compare Source

  • Added .resolved as alias to .fulfilled
  • Added .resolvedWith as alias to .fulfilledWith
  • All zero argument assertion will throw TypeError if any arg passed
  • Fix default export for TS definition

v13.0.1

Compare Source

  • Add missing UMD bundle for browser

v13.0.0

Compare Source

  • Removed .enumerable and .enumerables
  • Fixed .matching on Dates
  • Added TypeScript definitions

v12.0.0

Compare Source

  • Update should-equal to 2.x
  • Update entry points to do the same thing (global should entry)

Renovate configuration

📅 Schedule: "before 2am" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Apr 2, 2018
@ci-reporter
Copy link

ci-reporter bot commented Apr 2, 2018

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Travis CI build is failing as of 5d6204d. Here's the output:

npm test
> har@1.0.0 pretest /home/travis/build/ahmadnassri/har
> standard && echint


> har@1.0.0 test /home/travis/build/ahmadnassri/har
> mocha



  CacheEntry
    ✓ should use default value
    ✓ should use passed object

  Comment
    ✓ should use default value
    ✓ should use passed value

  Content
    ✓ should use default values
    ✓ should use object
    ✓ should manually override params
    ✓ should not allow setting size value

  Cookie
    ✓ should throw error when no data
    ✓ should throw error when no name
    ✓ should throw error when no value
    ✓ should use default values
    ✓ should use object

  Creator
    ✓ should throw error when no name
    ✓ should create a creator object (47ms)

  DateTime
    ✓ should use default values
    ✓ should use custom name value
    ✓ should use string value
    ✓ should use Date value
    ✓ should use Number value

  Entry
    ✓ should create an object with default values
    ✓ should set time property
    ✓ should set cache object
    ✓ should set timings object
    Required Fields
      ✓ should throw an error when missing options
      ✓ should throw an error when missing startedDateTime
      ✓ should throw an error when missing request
      ✓ should throw an error when missing response

  Log
    ✓ should fail without required params
    1) should create a log object with minimal values
    2) should create browser object
    Pages
      3) should add a single page using an object
      ✓ should add a single page using an instance
      4) should set pages on creation
      5) should set pages manually
    Entries
      ✓ should add a single entry using constructor
      ✓ should add a single entry using an instance
      ✓ should set entries on creation
      ✓ should set entries manually

  Page
    ✓ should create an empty object with default value
    ✓ should create a valid object
    ✓ should create a page object with set values

  Header
    ✓ should use default value
    ✓ should use name
    ✓ should use name & value
    ✓ should use name & value & comment
    ✓ should use object

  Param
    ✓ should use default values
    ✓ should use object

  PostData
    ✓ should use default values
    6) should use object
    7) should add a param
    8) should manually override params

  Request
    ✓ should throw error when no url
    9) should create an empty object with default values
    Headers
      10) should add a single header using an object
      ✓ should add a single header using an instance
      11) should set headers on creation
      12) should set headers manually
    Cookies
      13) should add a single cookie using an object
      ✓ should add a single cookie using an instance
      14) should set cookies on creation
      15) should set cookies manually
    queryString
      16) should add a single query using an object
      ✓ should add a single query using an instance
      17) should set queryString on creation
      18) should set queryString manually
    headersSize
      ✓ should not allow setting value
      ✓ should calculate headers size
    postData
      19) should allow setting postData from constructor
      ✓ should calculate postData size
      ✓ should not allow setting bodySize value

  Response
    ✓ should throw error when no url
    ✓ should create an empty object with default values
    Headers
      20) should add a single header using an object
      ✓ should add a single header using an instance
      21) should set headers on creation
      22) should set headers manually
    Cookies
      23) should add a single cookie using an object
      ✓ should add a single cookie using an instance
      24) should set cookies on creation
      25) should set cookies manually
    headersSize
      ✓ should not allow setting value
      ✓ should calculate headers size
    content
      ✓ should allow setting content from constructor
      ✓ should calculate content size
      ✓ should not allow setting bodySize value

  Util
    ✓ should convert a regular object to a HAR array pair
    ✓ should convert a HAR array pair to a regular object

  Version
    ✓ should fail without version value
    ✓ should use passed value
    ✓ should use force to string value


  67 passing (231ms)
  25 failing

  1) Log should create a log object with minimal values:
     TypeError: Cannot read property 'be' of undefined
      at Context.<anonymous> (test/log.js:36:58)

  2) Log should create browser object:
     TypeError: Cannot read property 'be' of undefined
      at Context.<anonymous> (test/log.js:58:58)

  3) Log Pages should add a single page using an object:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    startedDateTime: '2018-04-02T01:35:38.174Z',
    id: 'hello',
    title: 'hello world',
    pageTimings: Object { onLoad: 0, onContentLoad: 0 }
  }
] to equal Array [
  Object {
    id: 'hello',
    title: 'hello world',
    startedDateTime: '2018-04-02T01:35:38.174Z',
    pageTimings: Object { onLoad: 0, onContentLoad: 0 },
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  startedDateTime: '2018-04-02T01:35:38.174Z',
  id: 'hello',
  title: 'hello world',
  pageTimings: Object { onLoad: 0, onContentLoad: 0 }
} and B has Object {
  id: 'hello',
  title: 'hello world',
  startedDateTime: '2018-04-02T01:35:38.174Z',
  pageTimings: Object { onLoad: 0, onContentLoad: 0 },
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/log.js:91:45)

  4) Log Pages should set pages on creation:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    startedDateTime: '2018-04-02T01:35:38.184Z',
    id: 'hello',
    title: 'hello world',
    pageTimings: Object { onLoad: 0, onContentLoad: 0 }
  }
] to equal Array [
  Object {
    id: 'hello',
    title: 'hello world',
    startedDateTime: '2018-04-02T01:35:38.184Z',
    pageTimings: Object { onLoad: 0, onContentLoad: 0 },
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  startedDateTime: '2018-04-02T01:35:38.184Z',
  id: 'hello',
  title: 'hello world',
  pageTimings: Object { onLoad: 0, onContentLoad: 0 }
} and B has Object {
  id: 'hello',
  title: 'hello world',
  startedDateTime: '2018-04-02T01:35:38.184Z',
  pageTimings: Object { onLoad: 0, onContentLoad: 0 },
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/log.js:142:45)

  5) Log Pages should set pages manually:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    startedDateTime: '2018-04-02T01:35:38.188Z',
    id: 'hello',
    title: 'hello world',
    pageTimings: Object { onLoad: 0, onContentLoad: 0 }
  }
] to equal Array [
  Object {
    id: 'hello',
    title: 'hello world',
    startedDateTime: '2018-04-02T01:35:38.188Z',
    pageTimings: Object { onLoad: 0, onContentLoad: 0 },
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  startedDateTime: '2018-04-02T01:35:38.188Z',
  id: 'hello',
  title: 'hello world',
  pageTimings: Object { onLoad: 0, onContentLoad: 0 }
} and B has Object {
  id: 'hello',
  title: 'hello world',
  startedDateTime: '2018-04-02T01:35:38.188Z',
  pageTimings: Object { onLoad: 0, onContentLoad: 0 },
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/log.js:169:45)

  6) PostData should use object:

      AssertionError: expected Array [
  Object {
    comment: 'hello',
    name: 'foo',
    value: 'bar',
    contentType: 'text/plain',
    fileName: 'foo.bar'
  }
] to equal Array [
  Object {
    comment: 'hello',
    contentType: 'text/plain',
    fileName: 'foo.bar',
    name: 'foo',
    value: 'bar'
  }
] (at '0', A has Object {
  comment: 'hello',
  name: 'foo',
  value: 'bar',
  contentType: 'text/plain',
  fileName: 'foo.bar'
} and B has Object {
  comment: 'hello',
  contentType: 'text/plain',
  fileName: 'foo.bar',
  name: 'foo',
  value: 'bar'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/post-data.js:40:45)

  7) PostData should add a param:

      AssertionError: expected Array [
  Object {
    comment: 'hello',
    name: 'foo',
    value: 'bar',
    contentType: 'text/plain',
    fileName: 'foo.bar'
  }
] to equal Array [
  Object {
    comment: 'hello',
    contentType: 'text/plain',
    fileName: 'foo.bar',
    name: 'foo',
    value: 'bar'
  }
] (at '0', A has Object {
  comment: 'hello',
  name: 'foo',
  value: 'bar',
  contentType: 'text/plain',
  fileName: 'foo.bar'
} and B has Object {
  comment: 'hello',
  contentType: 'text/plain',
  fileName: 'foo.bar',
  name: 'foo',
  value: 'bar'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/post-data.js:70:45)

  8) PostData should manually override params:

      AssertionError: expected Array [
  Object {
    comment: 'hello',
    name: 'foo',
    value: 'bar',
    contentType: 'text/plain',
    fileName: 'foo.bar'
  }
] to equal Array [
  Object {
    comment: 'hello',
    contentType: 'text/plain',
    fileName: 'foo.bar',
    name: 'foo',
    value: 'bar'
  }
] (at '0', A has Object {
  comment: 'hello',
  name: 'foo',
  value: 'bar',
  contentType: 'text/plain',
  fileName: 'foo.bar'
} and B has Object {
  comment: 'hello',
  contentType: 'text/plain',
  fileName: 'foo.bar',
  name: 'foo',
  value: 'bar'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/post-data.js:100:45)

  9) Request should create an empty object with default values:

      AssertionError: expected Object {
  comment: undefined,
  mimeType: 'application/octet-stream',
  text: '',
  params: [Getter/Setter]
} to equal Object {
  mimeType: 'application/octet-stream',
  comment: undefined,
  params: Array [],
  text: ''
} (because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:40:53)

  10) Request Headers should add a single header using an object:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:67:51)

  11) Request Headers should set headers on creation:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:104:51)

  12) Request Headers should set headers manually:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:125:51)

  13) Request Cookies should add a single cookie using an object:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    expires: '2018-04-02T01:35:38.232Z',
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    httpOnly: true,
    secure: true
  }
] to equal Array [
  Object {
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    expires: '2018-04-02T01:35:38.232Z',
    httpOnly: true,
    secure: true,
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  expires: '2018-04-02T01:35:38.232Z',
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  httpOnly: true,
  secure: true
} and B has Object {
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  expires: '2018-04-02T01:35:38.232Z',
  httpOnly: true,
  secure: true,
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:153:51)

  14) Request Cookies should set cookies on creation:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    expires: '2018-04-02T01:35:38.236Z',
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    httpOnly: true,
    secure: true
  }
] to equal Array [
  Object {
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    expires: '2018-04-02T01:35:38.236Z',
    httpOnly: true,
    secure: true,
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  expires: '2018-04-02T01:35:38.236Z',
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  httpOnly: true,
  secure: true
} and B has Object {
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  expires: '2018-04-02T01:35:38.236Z',
  httpOnly: true,
  secure: true,
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:204:51)

  15) Request Cookies should set cookies manually:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    expires: '2018-04-02T01:35:38.238Z',
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    httpOnly: true,
    secure: true
  }
] to equal Array [
  Object {
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    expires: '2018-04-02T01:35:38.238Z',
    httpOnly: true,
    secure: true,
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  expires: '2018-04-02T01:35:38.238Z',
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  httpOnly: true,
  secure: true
} and B has Object {
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  expires: '2018-04-02T01:35:38.238Z',
  httpOnly: true,
  secure: true,
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:230:51)

  16) Request queryString should add a single query using an object:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:253:55)

  17) Request queryString should set queryString on creation:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:290:55)

  18) Request queryString should set queryString manually:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:311:55)

  19) Request postData should allow setting postData from constructor:

      AssertionError: expected Object {
  comment: 'bar',
  mimeType: 'text/plain',
  text: 'foo',
  params: [Getter/Setter]
} to equal Object {
  mimeType: 'text/plain',
  comment: 'bar',
  params: Array [],
  text: 'foo'
} (because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/request.js:359:55)

  20) Response Headers should add a single header using an object:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/response.js:63:52)

  21) Response Headers should set headers on creation:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/response.js:102:52)

  22) Response Headers should set headers manually:

      AssertionError: expected Array [ Object { comment: 'foo', name: 'foo', value: 'bar' } ] to equal Array [ Object { name: 'foo', value: 'bar', comment: 'foo' } ] (at '0', A has Object { comment: 'foo', name: 'foo', value: 'bar' } and B has Object { name: 'foo', value: 'bar', comment: 'foo' } because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/response.js:124:52)

  23) Response Cookies should add a single cookie using an object:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    expires: '2018-04-02T01:35:38.263Z',
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    httpOnly: true,
    secure: true
  }
] to equal Array [
  Object {
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    expires: '2018-04-02T01:35:38.263Z',
    httpOnly: true,
    secure: true,
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  expires: '2018-04-02T01:35:38.263Z',
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  httpOnly: true,
  secure: true
} and B has Object {
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  expires: '2018-04-02T01:35:38.263Z',
  httpOnly: true,
  secure: true,
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/response.js:153:52)

  24) Response Cookies should set cookies on creation:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    expires: '2018-04-02T01:35:38.265Z',
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    httpOnly: true,
    secure: true
  }
] to equal Array [
  Object {
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    expires: '2018-04-02T01:35:38.265Z',
    httpOnly: true,
    secure: true,
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  expires: '2018-04-02T01:35:38.265Z',
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  httpOnly: true,
  secure: true
} and B has Object {
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  expires: '2018-04-02T01:35:38.265Z',
  httpOnly: true,
  secure: true,
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/response.js:206:52)

  25) Response Cookies should set cookies manually:

      AssertionError: expected Array [
  Object {
    comment: 'foo',
    expires: '2018-04-02T01:35:38.269Z',
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    httpOnly: true,
    secure: true
  }
] to equal Array [
  Object {
    name: 'foo',
    value: 'bar',
    path: '/',
    domain: 'www.ahmadnassri.com',
    expires: '2018-04-02T01:35:38.269Z',
    httpOnly: true,
    secure: true,
    comment: 'foo'
  }
] (at '0', A has Object {
  comment: 'foo',
  expires: '2018-04-02T01:35:38.269Z',
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  httpOnly: true,
  secure: true
} and B has Object {
  name: 'foo',
  value: 'bar',
  path: '/',
  domain: 'www.ahmadnassri.com',
  expires: '2018-04-02T01:35:38.269Z',
  httpOnly: true,
  secure: true,
  comment: 'foo'
} because A and B have different prototypes)
      + expected - actual

      
      at Assertion.fail (node_modules/should/cjs/should.js:275:17)
      at Assertion.Object.defineProperty.value (node_modules/should/cjs/should.js:356:19)
      at Context.<anonymous> (test/response.js:233:52)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@renovate renovate bot changed the title chore(deps): update dependency should to ^13.0.0 chore(deps): update dependency should to v13 Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmadnassri @renovate-bot