-
Notifications
You must be signed in to change notification settings - Fork 247
go get does not work for a module-enabled project #240
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
go get -u -v gopkg.in/ahmdrz/goinsta.v2 |
go get -u -v github.com/ahmdrz/goinsta/v2 it works. |
@ngortheone Does |
@ahmdrz sorry, I have moved on to another project. I won't be able to verify any time soon |
@MarlikAlmighty could you please post the actual output of your test? It doesn't on my computer: $ go get -u -v github.com/ahmdrz/goinsta/v2
go: github.com/ahmdrz/goinsta/v2@v2.4.3: go.mod has non-.../v2 module path "github.com/ahmdrz/goinsta" (and .../v2/go.mod does not exist) at revision v2.4.3
go get: error loading module requirements |
@ahmdrz could you please try to change your |
|
@falzm |
@ahmdrz I managed to make it work by adding the following line to my
Then go get -u finally pulled the latest tag: $ go get -u github.com/ahmdrz/goinsta/v2
go: finding github.com/ahmdrz/goinsta v2.4.3
$ git diff
diff --git a/go.mod b/go.mod
index 118716b..7d2e356 100644
--- a/go.mod
+++ b/go.mod
@@ -4,9 +4,11 @@ go 1.12
require (
github.com/Masterminds/goutils v1.0.1
- github.com/ahmdrz/goinsta/v2 v2.4.1-0.20190510152949-903ea3101245
+ github.com/ahmdrz/goinsta/v2 v2.4.3
github.com/certifi/gocertifi v0.0.0-20180118203423-deb3ae2ef261 // indirect
github.com/getsentry/raven-go v0.2.0
github.com/gorilla/feeds v1.1.1
github.com/pkg/errors v0.8.1
)
+
+replace github.com/ahmdrz/goinsta/v2 => github.com/ahmdrz/goinsta v0.0.0-20190729052829-bf558a94ed9d
diff --git a/go.sum b/go.sum
index b196b5d..6768fcc 100644
--- a/go.sum
+++ b/go.sum
@@ -1,5 +1,7 @@
github.com/Masterminds/goutils v1.0.1 h1:upyB/JGR/aPHTE3f4O3mBIbJCr7aPup+/03IS4aXU6Y=
github.com/Masterminds/goutils v1.0.1/go.mod h1:8cTjp+g8YejhMuvIA5y2vz3BpJxksy863GQaJW2MFNU=
+github.com/ahmdrz/goinsta v0.0.0-20190729052829-bf558a94ed9d h1:a9WkfI+kd9zEhI0KDPgRMjQNgkFSs/4GudnkHppTwAA=
+github.com/ahmdrz/goinsta v0.0.0-20190729052829-bf558a94ed9d/go.mod h1:ZDXgVWGZMWUpg9hZx5gmPmo4/XjT3vE3xFt7EG079NQ=
github.com/ahmdrz/goinsta/v2 v2.4.1-0.20190323085700-ffd9e29a313a h1:lvtGW57Exf0L6PtsPNkKRIW9oY6bxPqVx1zr8KYTtfM=
github.com/ahmdrz/goinsta/v2 v2.4.1-0.20190323085700-ffd9e29a313a/go.mod h1:M6/Tnc41f4gn+rl9HxFaNY1c6Px5zQWHgyY6S/wSZFs=
github.com/ahmdrz/goinsta/v2 v2.4.1-0.20190510152949-903ea3101245 h1:W4UU/mMm1UKBCb0a+XpWPsVi3GB3aTiA1UlkwTR+VLU= I wonder if this issue isn't due to the fact that your v2 branch is not up-to-date corresponding to master. I guess if you declare that |
So before any tag release I have to make sure that v2 branch is synced with master branch. Right? |
I think so yes, but I'm not an expert in Go modules yet so I guess it's worth trying out :) |
@inliquid is |
|
@inliquid Thank you. |
|
What does |
Then you break those (including myself) who have |
I see. Thank you. |
Yes, it's fine now. I tried both v2 dependency for my project and v1, for that I used
|
@ahmdrz This is partially related to #174
I am porting https://github.com/tducasse/go-instabot to V2 version.
When I use go modules I can't install goinsta.
I also tried
I can install other libs with go get without problems, so I have high confidence that this is
goinsta
related problem. A side node - when I use the old GOPATH way - everything works fine.The text was updated successfully, but these errors were encountered: