Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined variable warning in class-amp-img-sanitizer.php #2848

Closed
Rkroy opened this issue Jan 25, 2019 · 6 comments
Closed

Undefined variable warning in class-amp-img-sanitizer.php #2848

Rkroy opened this issue Jan 25, 2019 · 6 comments
Assignees
@Zabi09
Labels
bug
Milestone
Wave

Comments

@Rkroy
Copy link
Collaborator

Rkroy commented Jan 25, 2019

Undefined variable: class in /home/chantrem/public_html/wp-content/plugins/accelerated-mobile-pages/includes/vendor/amp/includes/sanitizers/class-amp-img-sanitizer.php on line 105
@Zabi09 Zabi09 self-assigned this Jan 25, 2019
@Zabi09 Zabi09 added the bug label Jan 25, 2019
Zabi09 added a commit that referenced this issue Jan 25, 2019
@Zabi09
#2848 undefined variable class fixed
3e809d6
@ahmedkaludi ahmedkaludi added this to the Wave milestone Jan 29, 2019
@lcmartinezdev
Copy link

I have this issue too.

@pegazee
Copy link
Contributor

pegazee commented Feb 19, 2019

Hi @pycarlos ,

We've fixed this issue and it's forwarded to the testing department. Once the testing is done, we'll add the solution in the upcoming updates.

@pegazee
Copy link
Contributor

pegazee commented Feb 19, 2019 •
edited by syedimran22
Loading

** Review **

  • Kaleem

  • Imran

@mdkaleem95 mdkaleem95 removed their assignment Feb 20, 2019
@syedimran22 syedimran22 removed their assignment Feb 22, 2019
@MohammedKaludi
Copy link
Collaborator

👍

@Zabi09
Copy link
Contributor

Zabi09 commented Feb 28, 2019

Pushed in 0.9.97.37 - #2893

@pegazee
Copy link
Contributor

pegazee commented Feb 28, 2019 •
edited
Loading

Code is already in master v0.9.97.37

@pegazee pegazee closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zabi09 Zabi09

Labels
bug
Projects
None yet
Milestone
Wave
Development

No branches or pull requests
8 participants
@lcmartinezdev @ahmedkaludi @MohammedKaludi @pegazee @Zabi09 @mdkaleem95 @syedimran22 @Rkroy