Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default footer menu items of Design 3 http://take.ms/50LJt #613

Closed
ahmedkaludi opened this issue Feb 22, 2017 · 8 comments
Closed

Default footer menu items of Design 3 http://take.ms/50LJt #613

ahmedkaludi opened this issue Feb 22, 2017 · 8 comments
Assignees
Milestone

Comments

@ahmedkaludi
Copy link
Owner

Default footer menu items of Design 3 http://take.ms/50LJt

@MohammedKaludi
Copy link
Collaborator

Parent divs should be hidden too and for social icons as well as it is showing some gap

@MohammedKaludi
Copy link
Collaborator

@khaledMohammed000 have you fixed this? I'm still seeing the gap and blank ul http://take.ms/TCrLh

@khaledMohammed000
Copy link
Contributor

khaledMohammed000 commented Mar 3, 2017 via email

@MohammedKaludi
Copy link
Collaborator

Nope it is not fixed, as I failed it in the review,

@MohammedKaludi
Copy link
Collaborator

Also http://take.ms/4GXqW this should also be removed if no social icons

khaledMohammed000 added a commit that referenced this issue Mar 3, 2017
1. moved a checing function to features.php
2. added necessary conditions where required
@MohammedKaludi
Copy link
Collaborator

@khaledMohammed000 I still see this issue in design 3 http://take.ms/TCrLh

please check and send me the screenshot of your footer section

@khaledMohammed000
Copy link
Contributor

khaledMohammed000 commented Mar 3, 2017

@MohammedKaludi I have rechecked the above issue Perfectly works in my system http://take.ms/qitxK

MohammedKaludi added a commit that referenced this issue Mar 4, 2017
#613 Told you many times to check still filed in review
@MohammedKaludi
Copy link
Collaborator

@khaledMohammed000 Not happy with this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants