Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @ sign in context names. #145

Closed
idcmp opened this issue Apr 17, 2019 · 6 comments
Closed

Support @ sign in context names. #145

idcmp opened this issue Apr 17, 2019 · 6 comments

Comments

@idcmp
Copy link

idcmp commented Apr 17, 2019

In many environments it's common to have different roles authenticating to the same cluster. This generally results in contexts named "developer@cluster-1" or "admin@cluster-1", etc.

The current completion scripts do not properly digest the '@' sign (treating it as a separator).

@ahmetb
Copy link
Owner

ahmetb commented Apr 17, 2019

Huh, interesting. Any ideas why @ is treated as a separator?

Also, zsh or bash completion?

@idcmp
Copy link
Author

idcmp commented Apr 17, 2019

I'm using bash. I haven't poked too much into it, I'm guessing '@' is treated as a word separator by default but I don't know where that decision is made.

@loganmzz
Copy link

Has it been fixed ? I've no issue with Bash and @ in context names.

@idcmp
Copy link
Author

idcmp commented Jun 9, 2020

@loganmzz Can you confirm by "no issue", you mean you're generating the autocompletion and using it via tab successfully?

@loganmzz
Copy link

loganmzz commented Jun 9, 2020

Yes all my context names contains a @ and autocomplete nicely.

@idcmp
Copy link
Author

idcmp commented Jun 10, 2020

Perfect!

@idcmp idcmp closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants