Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectx -d: support multiple arguments #39

Closed
ahmetb opened this issue Apr 10, 2018 · 0 comments · Fixed by #46
Closed

kubectx -d: support multiple arguments #39

ahmetb opened this issue Apr 10, 2018 · 0 comments · Fixed by #46
Labels
😇Feature Request 🙏Help Wanted
Milestone
v0.6.0

Comments

@ahmetb
Copy link
Owner

ahmetb commented Apr 10, 2018 •
edited
Loading

I wish to see kubectx -d used to delete multiple commands at once. Ideally I should be able to say:

kubectx -d ctx1 ctx2

to delete multiple contexts.
@ahmetb ahmetb mentioned this issue Apr 10, 2018
Closed
@ahmetb ahmetb added this to the v0.6.0 milestone Apr 10, 2018
ahmetb added a commit that referenced this issue Apr 11, 2018
@ahmetb
Do not print colors if stdout isn't tty
4520d3f 
This is previously offered in #18, #22, and #27 and I previously rejected
these PRs. My rationale was to prevent scripting around kubectx as it is
meant to be used as an interactive tool.

But clearly that will be a problem, when you're doing operations like:

    kubectx -d $(kubectx)

which I proposed in #39. Plus this change is harmless. I think this
implementation does a better check than the previous ones.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb mentioned this issue Apr 11, 2018
Merged
uesteibar added a commit to uesteibar/kubectx that referenced this issue May 18, 2018
@uesteibar
Allow deleting multiple contexts at once
9b0fd3b 
fixes ahmetb#39

Example: `kubectx -d ctx1 ctx2`
@uesteibar uesteibar mentioned this issue May 18, 2018
Merged
uesteibar added a commit to uesteibar/kubectx that referenced this issue May 18, 2018
@uesteibar
Allow deleting multiple contexts at once
7428144 
fixes ahmetb#39

Example: `kubectx -d ctx1 ctx2`
uesteibar added a commit to uesteibar/kubectx that referenced this issue May 18, 2018
@uesteibar
Allow deleting multiple contexts at once
4a1d73d 
fixes ahmetb#39

Example: `kubectx -d ctx1 ctx2`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😇Feature Request 🙏Help Wanted
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

Allow deleting multiple contexts at once uesteibar/kubectx
1 participant
@ahmetb