-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix color in kubens success message #275
Conversation
This is a combination of 4 commits. * Fix color in kubens success message * Quote namespace in success message * Fix color when using %q format on Windows * Replaced %q with %s (Attribute to Jason Harmon <jason@jdharmon.com>)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@jdharmon Could you satisfy the google bot here and reply |
Isn't this what was already done in #228? |
Borrowed from @caarlos0 who mentioned a solution in #228, I think this is cleaned up for merge now in this PR.
Tested manually just a few cases, this appears to work 👍 let me know if I missed anything important @caarlos0