feat(kubens): added force flag to switch namespaces even if it doesn'… #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idsulik
force-pushed
the
feat-issue-333
branch
from
635dc0e
to
fdfa71d
Compare
|
@ahmetb Hi! |
|
Sorry, I mostly haven't gotten around reviewing it |
ahmetb
reviewed
Apr 15, 2024
|
@ahmetb hi! kindly remind you |
ahmetb
reviewed
Jun 24, 2024
README.md
Outdated
| Context "test" set. | ||
| Active namespace is "not-found-namespace". | ||
| --- | ||
| $ kubens not-found-namespace --f |
There was a problem hiding this comment.
Double dash is weird to see for single letter flags. Mistake?
cmd/kubens/flags.go
Outdated
| force := false | ||
|
|
||
| if n == 2 { | ||
| force = argv[1] == "--force" || argv[1] == "-f" |
There was a problem hiding this comment.
I think slices.Contains is better here? IMO people should be able to do both:
- kubens foo -f
- kubens -f foo
There was a problem hiding this comment.
pushed changes to support both versions
cmd/kubens/flags.go
Outdated
|
|
||
| if n == 2 { | ||
| force = argv[1] == "--force" || argv[1] == "-f" | ||
| } |
There was a problem hiding this comment.
There are some tests of this file, do you mind editing?
|
@ahmetb hi! is there anything else to do within the PR?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Added
--force&&-fflags tokubenscommand to switch namespace even if it doesn't exist.issue: #333
usage example