Skip to content

Commit

Permalink
Replace Glib::ThreadPool with c++11 threadpool implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
ahodesuka committed Nov 23, 2017
1 parent 2631ed7 commit 46a89b0
Show file tree
Hide file tree
Showing 2 changed files with 127 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/imagelist.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ using namespace AhoViewer;
#include "booru/image.h"
#include "naturalsort.h"
#include "settings.h"
#include "threadpool.h"

ImageList::ImageList(Widget *const w)
: m_Widget(w),
Expand Down Expand Up @@ -196,7 +197,7 @@ void ImageList::set_current(const size_t index, const bool fromWidget, const boo

void ImageList::load_thumbnails()
{
Glib::ThreadPool pool(std::thread::hardware_concurrency());
ThreadPool pool(std::thread::hardware_concurrency());
m_ThumbnailCancel->reset();

std::vector<size_t> indices(m_Images.size());
Expand All @@ -205,7 +206,7 @@ void ImageList::load_thumbnails()

for (const size_t i : indices)
{
pool.push([ this, i ]()
pool.enqueue([ this, i ]()
{
if (m_ThumbnailCancel->is_cancelled())
return;
Expand All @@ -220,8 +221,6 @@ void ImageList::load_thumbnails()
m_SignalThumbnailLoaded();
});
}

pool.shutdown(m_ThumbnailCancel->is_cancelled());
}

// Resets the image list to it's initial state
Expand Down
124 changes: 124 additions & 0 deletions src/threadpool.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,124 @@
/*
* Copyright (c) 2012 Jakob Progsch, Václav Zeman
*
* This software is provided 'as-is', without any express or implied
* warranty. In no event will the authors be held liable for any damages
* arising from the use of this software.
*
* Permission is granted to anyone to use this software for any purpose,
* including commercial applications, and to alter it and redistribute it
* freely, subject to the following restrictions:
*
* 1. The origin of this software must not be misrepresented; you must not
* claim that you wrote the original software. If you use this software
* in a product, an acknowledgment in the product documentation would be
* appreciated but is not required.
*
* 2. Altered source versions must be plainly marked as such, and must not be
* misrepresented as being the original software.
*
* 3. This notice may not be removed or altered from any source
* distribution.
*/

#ifndef THREAD_POOL_H
#define THREAD_POOL_H

#include <vector>
#include <queue>
#include <memory>
#include <thread>
#include <mutex>
#include <condition_variable>
#include <future>
#include <functional>
#include <stdexcept>

namespace AhoViewer
{
class ThreadPool {
public:
ThreadPool(size_t);
template<class F, class... Args>
auto enqueue(F&& f, Args&&... args)
-> std::future<typename std::result_of<F(Args...)>::type>;
~ThreadPool();
private:
// need to keep track of threads so we can join them
std::vector< std::thread > workers;
// the task queue
std::queue< std::function<void()> > tasks;

// synchronization
std::mutex queue_mutex;
std::condition_variable condition;
bool stop;
};

// the constructor just launches some amount of workers
inline ThreadPool::ThreadPool(size_t threads)
: stop(false)
{
for(size_t i = 0;i<threads;++i)
workers.emplace_back(
[this]
{
for(;;)
{
std::function<void()> task;

{
std::unique_lock<std::mutex> lock(this->queue_mutex);
this->condition.wait(lock,
[this]{ return this->stop || !this->tasks.empty(); });
if(this->stop && this->tasks.empty())
return;
task = std::move(this->tasks.front());
this->tasks.pop();
}

task();
}
}
);
}

// add new work item to the pool
template<class F, class... Args>
auto ThreadPool::enqueue(F&& f, Args&&... args)
-> std::future<typename std::result_of<F(Args...)>::type>
{
using return_type = typename std::result_of<F(Args...)>::type;

auto task = std::make_shared< std::packaged_task<return_type()> >(
std::bind(std::forward<F>(f), std::forward<Args>(args)...)
);

std::future<return_type> res = task->get_future();
{
std::unique_lock<std::mutex> lock(queue_mutex);

// don't allow enqueueing after stopping the pool
if(stop)
throw std::runtime_error("enqueue on stopped ThreadPool");

tasks.emplace([task](){ (*task)(); });
}
condition.notify_one();
return res;
}

// the destructor joins all threads
inline ThreadPool::~ThreadPool()
{
{
std::unique_lock<std::mutex> lock(queue_mutex);
stop = true;
}
condition.notify_all();
for(std::thread &worker: workers)
worker.join();
}
}

#endif

0 comments on commit 46a89b0

Please sign in to comment.