Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to upgrade our Rails app that uses default_url_options and "ArgumentError: Missing host to link to! Please provide the :host parameter, set default_url_options[:host], or set :only_path to true" started popping up during our specs.
It looks like this change in Rails: rails/rails@c41f08c makes the assumption that the keys will always be symbols.
Unfortunately this is happening:
Simply changing DefaultUrlOptions from a HashWithIndifferentAccess to a Hash seems to fix all of our issues. Thank you for your consideration.