Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#90] Fix CircleCI job #94

Merged
merged 12 commits into from
Jun 22, 2022
Merged

[#90] Fix CircleCI job #94

merged 12 commits into from
Jun 22, 2022

Conversation

ocean
Copy link
Collaborator

@ocean ocean commented Jun 13, 2022

This PR updates the Makefile to build an ahoy binary for testing, updates the test YML a little, and most importantly updates the CircleCI config file to hopefully fix the CI job running.

Drew Robinson added 3 commits June 13, 2022 17:28
Update Makefile to build test version of Ahoy
61ebcfc 
And replace golint (as it's deprecated) with staticcheck
Remove golint from testing .ahoy.yml config file
2732e90
Update CircleCI config to use latest Go Orb and build with Make
0bdf07c 
Also use CI caching, add golangci-lint.
Can't get PHP to install at the moment?
@ocean ocean requested a review from AlexSkrypnyk June 13, 2022 07:37
@ocean
Copy link
Collaborator Author

ocean commented Jun 13, 2022

May require some tweaking to get CI to pass so we can merge >_<

AlexSkrypnyk
AlexSkrypnyk reviewed Jun 16, 2022
View reviewed changes
Makefile Show resolved Hide resolved
AlexSkrypnyk
AlexSkrypnyk reviewed Jun 16, 2022
View reviewed changes
Makefile Show resolved Hide resolved
AlexSkrypnyk
AlexSkrypnyk approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocean
Please see my additions to your PR. The CI is passing now. Please merge at your earliest convenience.

@AlexSkrypnyk AlexSkrypnyk mentioned this pull request Jun 16, 2022
Merged
@AlexSkrypnyk AlexSkrypnyk changed the title Fix CircleCI job [#90] Fix CircleCI job Jun 16, 2022
@ocean
Copy link
Collaborator Author

ocean commented Jun 17, 2022

Argh!! This ci/circleci CircleCI job check on GH "must" pass before it can be merged! 😢

Must be an old GH repo config that is still stuck there. I'll chase @frankcarey on Twitter again to see if he can remove it.

@ocean ocean linked an issue Jun 17, 2022 that may be closed by this pull request
Get Automated tests working again #90
Closed
@frankcarey
Copy link
Contributor

I'll just force the merge then - hopefully that sorts it out.

@frankcarey frankcarey merged commit 861f002 into ahoy-cli:master Jun 22, 2022
@frankcarey
Copy link
Contributor

frankcarey commented Jun 22, 2022 •
edited
Loading

@ocean FYI, I replaced the one circleci Job in the "require to pass" section of the branch protection settings like so. (I removed the top entry after taking this screenshot) This issue should be resolved now.

image

@ocean
Copy link
Collaborator Author

ocean commented Jun 23, 2022

Fantastic, thanks @frankcarey for merging and I would think that should have fixed it! 🎉 🥳 👏

@ocean ocean deleted the fix-circleci-job branch June 24, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk AlexSkrypnyk approved these changes

Assignees

@ocean ocean

Labels
chore priority Ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Automated tests working again
3 participants
@ocean @frankcarey @AlexSkrypnyk