atdgen 1.10.2 causes infer 0.7.0 build breakage

[mjambon]

From @jayvdb on May 25, 2017 18:48

https://github.com/coala/coala-bears builds have been using infer 0.7.0 which built happily on Circle CI and Travis CI using atdgen 1.10.0 with ocaml 4.02.3/opam 1.2.2 from Ubuntu Trusty.

This broken recently, and we just noticed as our builds use a cached build of infer. Our issue for the breakage is coala/coala-bears#1763 .

The most obvious difference between old and new builds is that atdgen is now 1.10.2.

Building the latest version of infer from source works, but that is likely just working around the problem as it installed atdgen 1.6.0.

The fix (umerged coala/coala-bears#1765) pins atdgen to 1.10.0, and all is well when (I havent analysed this part very much) facebook's reason is also upgraded.

coala/coala-bears@6104b3f63d7efe11961 is the current master with the problem, and can be used to reproduce the problem even if we merge a workaround, but those builds are very long as it has a lot of crazy dependencies.

Copied from original issue: mjambon/atdgen#68

[mjambon]

From @rgrinberg on May 25, 2017 19:6

So this is the error:

atdgen -t backend/jsonbug.atd -o backend/jsonbug
atdgen -j backend/jsonbug.atd -o backend/jsonbug
atdgen -t backend/jsonbug.atd -o backend/jsonbug
fatal: Not a git repository: '../../.git'
atdgen -j backend/jsonbug.atd -o backend/jsonbug
fatal: Not a git repository: '../../.git'
...

...
gcc: error: /home/ubuntu/.opam/system/lib/atdgen/ag_util.o: No such file or directory
gcc: error: /home/ubuntu/.opam/system/lib/atdgen/ag_ob_run.o: No such file or directory
gcc: error: /home/ubuntu/.opam/system/lib/atdgen/ag_oj_run.o: No such file or directory
File "caml_startup", line 1:
Error: Error during linking

Can we see the actual compilation command that's causing it?

It's true that these various .o files aren't being installed anymore. But why are they even necessary? atdgen.a should be enough no?

[mjambon]

From @jayvdb on May 25, 2017 19:15

The full log with commands run can be seen at https://travis-ci.org/jayvdb/coala-bears/jobs/235904747

[mjambon]

From @jayvdb on May 25, 2017 19:36

Building the latest version of infer from source works, but that is likely just working around the problem as it installed atdgen 1.6.0.

fwiw, the 'but' there is wrong. I've now forced use of atdgen 1.10.2 with infer master (requiring ocaml 4.04.0), and that works properly.

[mjambon]

From @rgrinberg on May 25, 2017 19:51

Wait, so does 1.10.2 work with infer or not?

[mjambon]

From @jayvdb on May 25, 2017 19:52

This is about infer 0.7.0.