-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed all typos and broken links #17
Conversation
Thanks for this! Let me take a look at your changes :) |
I just noticed Github isn't showing all diff highlights correctly on web? Strange |
I also noticed this, but don't worry about it; I'll just run diff locally. So you'll have to wait until I have some time to sit at a computer :) |
Hi! I finally took the time to look through this. Sorry for the delay! The Your change under "Making Game Boy games" is wrong, instead it should say something like "other pieces of hardware, responsible for making graphics and sound, and interpreting input". The word "means" makes it even more unclear than it already was, IMO. The As for changing GPU to PPU, this change would need to include a brief explanation of what the PPU is. This is a book for game developers familiar with modern programming; we can expect them to know what a GPU is, but not a PPU. Simply explaining that the PPU is the Game Boy's variant of a GPU should be sufficient. Other than that, all your changes are correct and appreciated! |
I didn't change it because it was unclear, but I think Agreed with all others and I added the changes, if you still want to change something you have write access to my repos master branch. |
Hey good job on this. Just read through the entire thing ahead of https://github.com/ISSOtm/gb-asm-tutorial being finished. I managed to find a replacement for all broken links and I believe I found all typos.