Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all typos and broken links #17

Merged
merged 15 commits into from
Feb 25, 2023
Merged

Fixed all typos and broken links #17

merged 15 commits into from
Feb 25, 2023

Conversation

lesleyrs
Copy link
Contributor

Hey good job on this. Just read through the entire thing ahead of https://github.com/ISSOtm/gb-asm-tutorial being finished. I managed to find a replacement for all broken links and I believe I found all typos.

@ahrnbom
Copy link
Owner

ahrnbom commented Feb 14, 2023

Thanks for this! Let me take a look at your changes :)

@lesleyrs
Copy link
Contributor Author

I just noticed Github isn't showing all diff highlights correctly on web? Strange

@ahrnbom
Copy link
Owner

ahrnbom commented Feb 15, 2023

I also noticed this, but don't worry about it; I'll just run diff locally. So you'll have to wait until I have some time to sit at a computer :)

@ahrnbom
Copy link
Owner

ahrnbom commented Feb 23, 2023

Hi! I finally took the time to look through this. Sorry for the delay!

The sufficient detail vs sufficient enough detail thing, while both of them work, neither is ideal. Can we change it to sufficient level of detail?

Your change under "Making Game Boy games" is wrong, instead it should say something like "other pieces of hardware, responsible for making graphics and sound, and interpreting input". The word "means" makes it even more unclear than it already was, IMO.

The so some interrupt handling code is also wrong, this was not a typo. It refers to a specific code.

As for changing GPU to PPU, this change would need to include a brief explanation of what the PPU is. This is a book for game developers familiar with modern programming; we can expect them to know what a GPU is, but not a PPU. Simply explaining that the PPU is the Game Boy's variant of a GPU should be sufficient.

Other than that, all your changes are correct and appreciated!

@lesleyrs
Copy link
Contributor Author

Your change under "Making Game Boy games" is wrong, instead it should say something like "other pieces of hardware, responsible for making graphics and sound, and interpreting input". The word "means" makes it even more unclear than it already was, IMO.

I didn't change it because it was unclear, but I think that make ... isn't proper English? Not a native speaker though. I didn't want to change it too much but that means, that makes or that consists of all sound better IMO but I reverted it.

Agreed with all others and I added the changes, if you still want to change something you have write access to my repos master branch.

@ahrnbom ahrnbom merged commit df82c9c into ahrnbom:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants