Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Docker #132

Merged
merged 12 commits into from
Feb 15, 2017
Merged

Updated Docker #132

merged 12 commits into from
Feb 15, 2017

Conversation

davidadley
Copy link

Updates the Dockerfile using ROS-Kinetic or Ubuntu 16.04 as the base image.
It is a complicated docker file and sometimes needs to be run twice.

@ahundt
Copy link
Owner

ahundt commented Feb 13, 2017

Thanks this looks awesome! Can you add a little info for when each script is appropriate to run?

@davidadley
Copy link
Author

davidadley commented Feb 13, 2017

Hi no problem:

For basic Ubuntu 16.04 build:
InstallDocker.sh - InstallsDocker on a base system without it
Build.sh - Builds the docker image using the Dockerfile
Run.sh - runs a container using the built image with access to X11 for V-REP.

The run.sh file could be more advanced as it starts a new container everytime it is run and doesn't restart and attach to an existing container. Knowledge of docker is an advantage here. If you wish to restart and attach to an existing container you also need to set xhost +local:root.

xhost +local:root && docker start 'name of container' && docker attach 'name of container'

An alternative is to commit the container with modifications to the base image:

docker commit 'name of container' 'name of image e.g. xenial-grl:nvidia'

then simply use the ./run.sh script

If using the ROS-kinetic base image from OSRF (See dockerfile for details):
pre-conf.sh is used to create and build the catkin workspaces
startup.sh is run everytime the system is run. It really only needs to be run once. Both these files are copied into the docker image while it is being built and shouldn't be run by the user. They could be put into a separate 'ROS' or 'config' directory to make the layout clearer. I tried to eliminate them but couldn't it caused strange docker errors. Maybe in the future I'll give it another shot.

@ahundt
Copy link
Owner

ahundt commented Feb 14, 2017

@davidadley sorry I meant in like a README.md in this folder of the code, then I can accept the pull request. Thanks!

@ahundt ahundt merged commit 724c8b8 into ahundt:master Feb 15, 2017
@ahundt
Copy link
Owner

ahundt commented Feb 15, 2017

@davidadley awesome thanks for the update ! Are you able to drive your Kuka with this?

@davidadley
Copy link
Author

davidadley commented Feb 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants