Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use comparable benchmarker #1

Closed
Relequestual opened this issue Oct 27, 2021 · 4 comments
Closed

Suggestion: Use comparable benchmarker #1

Relequestual opened this issue Oct 27, 2021 · 4 comments

Comments

@Relequestual
Copy link

There exists a benchmarking tool. It would be great if you could use that, which would allow your benchmark to be comparable.

https://github.com/ebdrup/json-schema-benchmark

@ahungrynoob
Copy link
Owner

Thank you for your attention.
Hmmm... After I redesigned the api and did the benchmark, ajv is recommended to use instead of this lib.
N-API take much huger overhead then calculate if json meet schema.

@Relequestual
Copy link
Author

Yikes! That's supprising!
Can you determine which tests were much slower?

@ahungrynoob
Copy link
Owner

@Relequestual All the tests, because the call of napi take huge overhead

@Relequestual
Copy link
Author

OOOOh I understand. Damn.
Still, doesn't mean it's not useful for allowing different implementations to be testable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants