Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting note title doesn't really delete title in database #126

Closed
qingshuizheng opened this issue Dec 21, 2023 · 2 comments
Closed

Deleting note title doesn't really delete title in database #126

qingshuizheng opened this issue Dec 21, 2023 · 2 comments

Comments

@qingshuizheng
Copy link
Contributor

qingshuizheng commented Dec 21, 2023

Hello @ahyatt ,

Seems deleting note title to empty, doesn't really delete title in database. I will need to delete it manually:

(triples-remove-type ekg-db id 'titled)

Original note for comparison:
iShot_2023-12-21_11 14 00

Delete the title to empty and finalize it, the title still exists and appears as a empty string , which was underlined:
image
(ekg-current-note-or-error)

#s(ekg-note 33524290367 "When note title is delete to empty, the title line(s) should disppear" org-mode ("date/2023-12-21") 1703128003 1703128452 (:titled/title ("")) nil)

--

BTW, hours ago I had another comment in cc20f36#r135411436

I thought that was a fix for this, but turns out that was just a fix for collecting empty titles.

--

Thanks.

Edit:
update 2nd pic;
upload note info

qingshuizheng referenced this issue Dec 21, 2023
Now properties can have multiple lines in the metadata section. The new const
ekg-property-multivalue-type controls how multivalued properties act. This fixes
#110.
@ahyatt
Copy link
Owner

ahyatt commented Dec 21, 2023

Thanks for the report. Can you verify that the fix I submitted works?

ahyatt added a commit that referenced this issue Dec 21, 2023
For example, titles should be deleted when deleting previous titles. Resources
should reset to a normal resource id when deleted. This changes both the editor
behavior (these are no-longer read-only), and the new ability to understand what
fields have been deleted and remove the type when appropriate.

This fixes #126.
@qingshuizheng
Copy link
Contributor Author

qingshuizheng commented Dec 21, 2023

Can you verify that the fix I submitted works?

Thanks for the quick fix! It works!

For the commit cc20f36 to separate multiple titles with comma in ekg-notes-mode, I think you base this idea on the fact that default ekg-title face has underline property in it. The user might change it to a face without underline tho. Just a concern, you call it. Otherwise, this issue could be closed.

Thanks!

@ahyatt ahyatt closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants