-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting note title doesn't really delete title in database #126
Comments
Now properties can have multiple lines in the metadata section. The new const ekg-property-multivalue-type controls how multivalued properties act. This fixes #110.
Thanks for the report. Can you verify that the fix I submitted works? |
For example, titles should be deleted when deleting previous titles. Resources should reset to a normal resource id when deleted. This changes both the editor behavior (these are no-longer read-only), and the new ability to understand what fields have been deleted and remove the type when appropriate. This fixes #126.
Thanks for the quick fix! It works! For the commit cc20f36 to separate multiple titles with comma in Thanks! |
Hello @ahyatt ,
Seems deleting note title to empty, doesn't really delete title in database. I will need to delete it manually:
(triples-remove-type ekg-db id 'titled)
Original note for comparison:
![iShot_2023-12-21_11 14 00](https://private-user-images.githubusercontent.com/78839107/292077143-419c1b23-7c99-4e1a-844c-77713f97020f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NTcyNjEsIm5iZiI6MTcyNTU1Njk2MSwicGF0aCI6Ii83ODgzOTEwNy8yOTIwNzcxNDMtNDE5YzFiMjMtN2M5OS00ZTFhLTg0NGMtNzc3MTNmOTcwMjBmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDE3MjI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3Y2RhYmFjMGRlNDk3MWY4ZDBjNGQ4MWE4ZTBiMmFhNjc5NGMxOTViODYwZTlhNGZhZDY2M2NlNzA3YjQzYWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.e2ENDFwz7od1h2uyOOOc5KKh7IlOxPCruv9c9kTzEmU)
Delete the title to empty and finalize it, the title still exists and appears as a empty string , which was underlined:
![image](https://private-user-images.githubusercontent.com/78839107/292080821-387811e1-6160-4d2e-be62-9e0c9c055283.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU1NTcyNjEsIm5iZiI6MTcyNTU1Njk2MSwicGF0aCI6Ii83ODgzOTEwNy8yOTIwODA4MjEtMzg3ODExZTEtNjE2MC00ZDJlLWJlNjItOWUwYzljMDU1MjgzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA1VDE3MjI0MVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRhNGI3Njk5ZmRkZTU5YjM1Y2I1YWE2NGQyZTU5MmM5ZDkzMzcyNDI0N2VhMGI0ZDAyOTQ4NGE4ZmUyNzhhMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.sS9AfT56zwU5r3YNsOfoU8Y2KzjXsi6L2nuAeAPlvGA)
(ekg-current-note-or-error)
--
BTW, hours ago I had another comment in cc20f36#r135411436
I thought that was a fix for this, but turns out that was just a fix for collecting empty titles.
--
Thanks.
Edit:
update 2nd pic;
upload note info
The text was updated successfully, but these errors were encountered: