Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35: Update finesse-frontend deployment workflow #45

Closed
wants to merge 3 commits into from
Closed

Fixes #35: Update finesse-frontend deployment workflow #45

wants to merge 3 commits into from

Conversation

vivalareda
Copy link
Contributor

@vivalareda vivalareda commented Nov 24, 2023 •
edited
Loading

@vivalareda vivalareda linked an issue Nov 24, 2023 that may be closed by this pull request
Update finesse-frontend deployment workflow #35
Closed
rngadam
rngadam suggested changes Nov 24, 2023
View reviewed changes
src/_versions.ts Outdated Show resolved Hide resolved
@vivalareda vivalareda changed the title Fixes #35: Add deployment to vercel for finesse-frontend Fixes #35: Update finesse-frontend deployment workflow Nov 25, 2023
@vivalareda vivalareda marked this pull request as draft November 25, 2023 14:07
This was referenced Nov 27, 2023
Open
Open
rngadam
rngadam suggested changes Nov 27, 2023
View reviewed changes
.github/workflows/vercel-deployment.yml Outdated Show resolved Hide resolved
rngadam
rngadam suggested changes Nov 27, 2023
View reviewed changes
.github/workflows/vercel-deployment.yml Outdated Show resolved Hide resolved
@vivalareda vivalareda mentioned this pull request Dec 1, 2023
Merged
@vivalareda vivalareda marked this pull request as ready for review December 2, 2023 20:04
rngadam
rngadam suggested changes Dec 5, 2023
View reviewed changes
.github/workflows/gh-pages-deployment.yml Outdated Show resolved Hide resolved
src/_versions.ts Outdated Show resolved Hide resolved
src/components/searchbar/SearchBar.tsx Outdated Show resolved Hide resolved
.github/workflows/vercel-deployment.yml Outdated Show resolved Hide resolved
.github/workflows/vercel-deployment.yml Outdated Show resolved Hide resolved
ThomasCardin
ThomasCardin approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ThomasCardin ThomasCardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-allagbe k-allagbe mentioned this pull request Dec 5, 2023
Merged
10 tasks
rngadam
rngadam suggested changes Dec 6, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/_versions.ts Outdated
versionLong: '0.1.0-499e4ad',
versionDate: '2023-11-24T21:13:58.324Z',
gitCommitHash: '6924943e',
versionLong: '0.1.0-6924943e',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionLong is 0.1.0 but version is 0.1.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copy pasted the one from main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is supposed to be generated, we can't have the version going back.

Copy link
Contributor Author

@vivalareda vivalareda Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the version to 0.2.0 this is what it is on main and then fixed the merge issue I don't really understand if I am suppose to have the same things as main if it's generated tho but it appeared on the merge conflict so I'm guessing yes

@vivalareda vivalareda mentioned this pull request Dec 6, 2023
Closed
@rngadam
Copy link
Contributor

rngadam commented Dec 13, 2023

19 commits for 3 lines change is a bit much; rebase

@vivalareda
parent 4c130e3
c45c09e 
author reda <tarzaltreda@gmail.com> 1700762752 +0000
committer reda <tarzaltreda@gmail.com> 1703009832 -0500

issue #38: add deployment file

issue #35: testing deployment with changes

issue #35: minor fix

issue #16: fix placeholder query + tests

issue #16: update version
@vivalareda vivalareda force-pushed the 35-update-finesse-frontend-deployment-workflow branch from 983d866 to c45c09e Compare December 19, 2023 18:20
@rngadam
Copy link
Contributor

rngadam commented Jan 10, 2024

Something seems to have gone wrong in rebasing this PR as it lists a lot of changes that were already on the base branch so the net result is two lien change to .gitignore and ignoring a subdirectory that doesn't seem to be related to issue #35

image

Going to abandon this PR.

@rngadam rngadam closed this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasCardin ThomasCardin ThomasCardin approved these changes

@rngadam rngadam Awaiting requested review from rngadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update finesse-frontend deployment workflow
3 participants
@vivalareda @rngadam @ThomasCardin