Skip to content

Commit

Permalink
Reemove Sprockets 3
Browse files Browse the repository at this point in the history
  • Loading branch information
ai committed Jul 16, 2018
1 parent fd0abcd commit 046ec5e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 20 deletions.
11 changes: 1 addition & 10 deletions .travis.yml
Expand Up @@ -6,9 +6,6 @@ rvm:
git:
depth: 5
cache: bundler
gemfile:
- sprockets3.gemfile
- sprockets4.gemfile
before_install:
- nvm install node
env:
Expand All @@ -21,10 +18,4 @@ matrix:
env: "EXECJS_RUNTIME=Node"

- rvm: "2.4"
gemfile: sprockets3.gemfile

- rvm: "2.5"
gemfile: sprockets3.gemfile

- env: "EXECJS_RUNTIME=Node"
gemfile: mini_racer.gemfile
env: "EXECJS_RUNTIME=Node"
10 changes: 9 additions & 1 deletion Gemfile
@@ -1 +1,9 @@
eval_gemfile "#{ File.dirname(__FILE__) }/sprockets4.gemfile"
source 'https://rubygems.org'

gemspec

gem 'execjs'
gem 'rails', '>= 5.0.0.beta2'
gem 'sprockets', '>= 4.0.0.beta1'

gem 'mini_racer'
9 changes: 0 additions & 9 deletions sprockets3.gemfile

This file was deleted.

3 comments on commit 046ec5e

@rmehner
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there,

I saw that you removed support for Sprockets 3, even though it's the latest stable version and Sprockets 4 is still beta. What is the reasoning behind this? Trying to read up before I upgrade on my projects and it feels like I've missed something :)

Thank you 🙇

@ai
Copy link
Owner Author

@ai ai commented on 046ec5e Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought Sprockets 4 was released, since they make it free years ago.

Don't worry, I didn't remove the support itself. Just removed it from test to make Travis CI faster.

@rmehner
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ai thanks for the clarification. I saw that this is only related to tests, but wanted to make sure I didn't miss any big Sprockets 3 vs. 4 news :)

Thanks again and have a great day!

Please sign in to comment.