New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoprefixer version detection broken with latest execjs #160
Comments
What ExecJS runtime so you use? |
Node, the vanilla one. |
What Node.js version? |
Oh sorry, v10.16.0. I think it also happens for node 8, but as part of my troubleshooting I've standardized on node 10 and it's tough to go back and test. |
Hm. |
Given the code there, it has to be calling `node` at least.... I've
verified the shell's node version using `system('node --version')` and it's
the correct version so...
…On Wed, Jul 3, 2019 at 2:50 PM Andrey Sitnik ***@***.***> wrote:
Hm. process is not null on Node.js 10. Maybe ExecJS uses different engine
because of some issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#160?email_source=notifications&email_token=AAEUHHBA3LQPB7TMYCPCRYLP5T7IBA5CNFSM4H5IKU22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZFQESQ#issuecomment-508232266>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEUHHEIFS5EP3E4VHUSH2TP5T7IBANCNFSM4H5IKU2Q>
.
--
Aleks Clark
cell: 775-391-6114
|
User can pass custom |
We have a different question here. |
I completely agree! I've created a minimal test case, can you try it? https://github.com/aleksclark/autoprefixer-bug-repro |
Also, here's the version that does work: As you can see, the difference is in using the latest version of execjs. The problem is that the latest release of execjs is quite old, and does not prefer |
Do we need to fix the problem if it is related with old ExecJS and could be a bug, which they fixed? |
The problem happens with new ExecJS (current master). Old execjs works
fine. I think `process` not being available could be considered a bug in
ExecJS, but I'm not sure if they consider that part of the public API.
…On Wed, Jul 3, 2019 at 4:21 PM Andrey Sitnik ***@***.***> wrote:
Do we need to fix the problem if it is related with old ExecJS and could
be a bug, which they fixed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#160?email_source=notifications&email_token=AAEUHHF5OWEOPQQGPU7AVV3P5UJ3ZA5CNFSM4H5IKU22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZFWXGY#issuecomment-508259227>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEUHHAM5FCCCTV44YKL5NTP5UJ3ZANCNFSM4H5IKU2Q>
.
--
Aleks Clark
cell: 775-391-6114
|
I afraid that without stdlib I can garantee that other I am closing this issue, since I have no idea how to fix it. |
With the following versions:
Autoprefixer seems to be using an invalid way of detecting node versions:
This code throws a TypeError, because
process
is null. If I comment out the check, autoprefixer seems to be functioning correctly.The text was updated successfully, but these errors were encountered: