Fix parsing tsconfig in json5 format (#32)

ai · Feb 4, 2023 · 658cc6b · 658cc6b
1 parent c22b3a0
commit 658cc6b
Show file tree

Hide file tree

Showing 4 changed files with 57 additions and 14 deletions.
diff --git a/check.js b/check.js
@@ -7,6 +7,7 @@ import { location } from 'vfile-location'
 import { Worker } from 'worker_threads'
 import pico from 'picocolors'
 import glob from 'fast-glob'
+import JSON5 from 'json5'
 
 let require = createRequire(import.meta.url)
 
@@ -76,7 +77,7 @@ export async function check(
   let compilerOptions
   let tsconfigPath = join(cwd, 'tsconfig.json')
   if (existsSync(tsconfigPath)) {
-    let tsconfig = JSON.parse(await fs.readFile(tsconfigPath))
+    let tsconfig = JSON5.parse(await fs.readFile(tsconfigPath))
     compilerOptions = tsconfig.compilerOptions
   }
 

diff --git a/package.json b/package.json
@@ -21,6 +21,7 @@
   },
   "dependencies": {
     "fast-glob": "^3.2.11",
+    "json5": "^2.2.3",
     "nanospinner": "^1.1.0",
     "picocolors": "^1.0.0",
     "vfile-location": "^4.0.1"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/fixtures/tsconfig/tsconfig.json b/test/fixtures/tsconfig/tsconfig.json
@@ -1,10 +1,11 @@
 {
+  // tsconfig should support comments
   "compilerOptions": {
     "target": "ES5",
     "experimentalDecorators": true,
     "moduleResolution": "Node",
     "lib": [
       "ES2020.Promise"
     ]
-  }
+  }, // tsconfig should support trailing commas
 }