Another way to clean after tests

ai · Dec 8, 2022 · a8592e5 · a8592e5
1 parent 264c25b
commit a8592e5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/test/async.test.js b/test/async.test.js
@@ -5,15 +5,21 @@ import { urlAlphabet } from '../index.js'
 import * as browser from '../async/index.browser.js'
 import * as node from '../async/index.js'
 
-Object.defineProperty(global, 'crypto', {
-  value: {
-    getRandomValues(array) {
-      for (let i = 0; i < array.length; i++) {
-        array[i] = Math.floor(Math.random() * 256)
+test.before(() => {
+  Object.defineProperty(global, 'crypto', {
+    value: {
+      getRandomValues(array) {
+        for (let i = 0; i < array.length; i++) {
+          array[i] = Math.floor(Math.random() * 256)
+        }
+        return array
       }
-      return array
     }
-  }
+  })
+})
+
+test.after(() => {
+  Object.defineProperty(global, 'crypto', { value: undefined })
 })
 
 function times(size, callback) {

diff --git a/test/index.test.js b/test/index.test.js
@@ -6,7 +6,6 @@ import * as node from '../index.js'
 
 test.before(() => {
   Object.defineProperty(global, 'crypto', {
-    configurable: true,
     value: {
       getRandomValues(array) {
         for (let i = 0; i < array.length; i++) {
@@ -19,7 +18,7 @@ test.before(() => {
 })
 
 test.after(() => {
-  delete global.crypto
+  Object.defineProperty(global, 'crypto', { value: undefined })
 })
 
 for (let type of ['node', 'browser']) {

diff --git a/test/react-native-polyfill.test.js b/test/react-native-polyfill.test.js
@@ -23,7 +23,7 @@ test.before(() => {
 
 test.after(() => {
   delete global.navigator
-  delete global.crypto
+  Object.defineProperty(global, 'crypto', { value: undefined })
 })
 
 test('works with polyfill', () => {