Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12 Oval hybrids for hybrids MX-Alps footprints #15

Closed
wants to merge 7 commits into from

Conversation

dsanchezseco
Copy link

This modded footprints have 1 oval hole for each of the switch pads instead of 2 overlaping pads. This also removes the DRC error from Kicad about overlaping pads/drilled holes being to close.
All the modded footprints' pads have the same dimensions as the original overlapping ones.

They look like this.
Screenshot_20200517_131510

@ghost
Copy link

ghost commented Aug 1, 2020

Thank you for this! Those DRC errors were really bugging me 🙂.

@WardBenjamin
Copy link

WardBenjamin commented Aug 9, 2020

Looks good!

I would like to see a compromise between this and the original version where pin 2 is slotted while pin 1 is not, so that it fixes the drill too close DRC error while still maintaining the positioning benefits of separate holes.

@dsanchezseco
Copy link
Author

@WardBenjamin the problem with that is that you'll need to connect both holes with traces as is not possible to do it on the footprint. Either that or as it is now that pops the DRC error

@WardBenjamin
Copy link

WardBenjamin commented Aug 9, 2020

image

@dsanchezseco currently, the DRC error only appears on pin 2, and KiCad correctly recognizes pin 1 as being connected to the second PTH (you can see this on the airwire, but I also confirmed on the DRC unconnected report).

@dsanchezseco
Copy link
Author

Oops forgot about that, it's been a while since I did it

@WardBenjamin
Copy link

@dsanchezseco I'd be happy to make that change and PR to your fork if you'd like, to include that change in this PR

@dsanchezseco
Copy link
Author

@WardBenjamin sure, go ahead

@WardBenjamin
Copy link

@dsanchezseco is it intentional that holes are only present in one of the two mask layers? That seems like an error to me but just wanted to double check.

@dsanchezseco
Copy link
Author

@WardBenjamin My bad, it was an old version, check now. But i think I changed the silks on this version tho

@WardBenjamin
Copy link

Looks good, I've got the updates now. I like the silkscreen change as well, good work.

@dsanchezseco
Copy link
Author

Thanks!

@WardBenjamin
Copy link

WardBenjamin commented Aug 9, 2020

@dsanchezseco to verify: are pads 1/2 the same in every footprint? Right now I'm manually checking the diff but if I can just find and replace in every file it'd be done zippy quick.

Edit: It looks like they are based on a search; I'll verify visually as well.

@dsanchezseco
Copy link
Author

@WardBenjamin yes they are, i'd edited all in the text editor, so it should

@WardBenjamin
Copy link

As per the PR I linked, it would be nice to also have these footprints in the KiCad standard library for reuse instead of having them scattered across various Github repositories (to reduce confusion and reduce the barrier to entry). I am willing to help out with this.

@perigoso perigoso mentioned this pull request Aug 15, 2020
@perigoso
Copy link

perigoso commented Aug 15, 2020

I'm starting an effort to merge the library to the official libraries, I am including these changes. #11

@ai03-2725
Copy link
Owner

Apologize for the ridiculous delay; finally got around to checking pending PRs after too long.
I will have to decline this PR, for the holes were purposely split apart into two rather than oval based on past experiences with similar footprints and the reduced chance of user assembly error when using the split hole design.
If the footprints are supplied as an entirely separate collection (i.e. MX_Alps_Hybrid_Ovals.pretty subfolder), it might be worthwhile since it allows for the option for using such footprints if desired without breaking changes on numerous existing PCB projects.

@dsanchezseco
Copy link
Author

Sorry for the delay from my side(hahahaha), yeah, it totally makes sense. Now that I assembled one pcb without plate I understand why there was two holes.

Thanks for the awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants