Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook image and update for no storage #418

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Fix notebook image and update for no storage #418

merged 4 commits into from
Dec 22, 2022

Conversation

jdahm
Copy link
Contributor

@jdahm jdahm commented Dec 22, 2022 •
edited
Loading

Purpose

  • Adds a non-editable install of the pace modules in the Docker build.
  • Removes the default_origin keyword argument in one call to gt4py.storage.zeros in an example notebook.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jdahm jdahm mentioned this pull request Dec 22, 2022
Open
mcgibbon
mcgibbon approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@mcgibbon mcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May want to add a comment describing why the non-edit installs were needed.

@jdahm jdahm merged commit 0ccc2ca into main Dec 22, 2022
@jdahm jdahm deleted the fix-notebook-image branch December 22, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcgibbon mcgibbon mcgibbon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdahm @mcgibbon