Allow whitespace after rating ranges #195
Conversation
e.g. parse 5000+, in addition to 5000+ Reorder parsing of ranges like 4000-5000 to before 5000-, as otherwise 4000-5000 will now be interpreted as 4000-
|
Anybody want to check this one for me? |
|
I don't understand the whitespace (assuming that's what "whitespare" was supposed to be) change, in the first comment it looks like you just typed "5000+" twice. Regardless, it looks like parsing the range doesn't work right. In the console, I got this:
|
|
This was to fix the issue #193, in which florrat discovered that appending a comma to the rating criteria disables it. That was because I was using a lookahead: (?!\S) at the end of the regex, which prohibits a non-whitespace character from immediately following the expression. I had thought to prevent parsing unintended range criteria, but on further consideration, such table names are pretty far fetched. Something like "AI's game 2012-2013 was awesome! #vpon" is pretty much never going to happen, while florrat's "florrat 4000+, #vpon" is obviously quite reasonable. People probably also try stuff like "... 4000+#vpon" to save space. Edit: okay, my lookahead wouldn't even have protected against "2012-2013". It would have to be something even weirder like "Dec2012-Jan2013 were awesome." And yes, I seem to have broken the parsing logic. Sorry, I'll fix and test more thoroughly before resubmitting. |
Matches of the form "2000-3000" were being interpreted first in its entirety as a bounded range and then again as "2000-". Now the match checks are in an if-else chain instead, so the first match ends the parsing.
|
Fixed and tested. |
|
I can take a look this evening. |
aiannacc
changed the title
Allow whitespace after rating ranges
e.g. parse 5000+, in addition to 5000+
Reorder parsing of ranges like 4000-5000 to before 5000-, as otherwise
4000-5000 will now be interpreted as 4000-