Better end turn #239
Merged
Better end turn #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidebar to reduce the chance of turn-ending misclicks
|
I'm confused. I don't see any change. Testing on Chromium 33 on Arch Linux. |
|
Did you check "Better End Turn button" in the settings dialog? It's under the "Game" tab. |
|
Duh. Okay. Great work! |
|
Thanks! 👍 |
|
Just tried this on Chrome 35, OSX 10.9.3, and I was seeing multiples of the new "End Turn" button. They all worked, there was just a row of them, one for each game I played with the option on, like so: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Goko's "End Turn" button with one in the Salvager sidebar, should reduce the chance of ending your turn by misclick.
Also includes a JSLint setting tweak so that everything passes JSLint again.
Tested in latest Chrome and Firefox on OS X Mavericks.