Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only build ros2-ws and ros2-control #97

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Conversation

domire8
Copy link
Contributor

@domire8 domire8 commented Sep 11, 2023

Description

This one hurts a bit because it removes a lot of code that took some effort to make it work hehe. But as discussed in the topic, we only want to build ros2-ws and ros2-control images and then just add control-libraries and modulo as desired. For that we can remove all the workflows that check if those two repos have new changes. Additionally, there is now also a build with a manifest merge now, such that all pushed images have a proper tag.

Review guidelines

Estimated Time of Review: 10 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 linked an issue Sep 11, 2023 that may be closed by this pull request
Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely cleaner and the deleted code is not lost, since we absorbed it all as knowledge and lessons learned along the way!

As a side note, how do you feel about tagging the ros2-control image with the version (for example, as :iron and :iron-3.18)? That way if we keep iron but upgrade ros2_control to some other version later, we can distinguish them. Not in scope for this PR but goes in a similar direction and I think would be useful to do.

@domire8
Copy link
Contributor Author

domire8 commented Sep 11, 2023

Yes, I guess that would make sense. Not sure how we would extract that though because technically it's not just the ros2control version that represents that image but also the combination of all the other repos that we have to clone.

@LouisBrunner
Copy link
Contributor

I think we should just make our own version for this. e.g. v2.3.0+iron

@domire8
Copy link
Contributor Author

domire8 commented Sep 11, 2023

I think we should just make our own version for this. e.g. v2.3.0+iron

Fair suggestion, do we take the version from a VERSION file?

@domire8
Copy link
Contributor Author

domire8 commented Sep 11, 2023

Let's continue discussing in #82 . Is this one good to go?

@domire8 domire8 merged commit aaaafdd into main Sep 11, 2023
16 checks passed
@domire8 domire8 deleted the feature/ws-control-only branch September 11, 2023 18:20
@domire8 domire8 restored the feature/ws-control-only branch December 4, 2023 09:35
@domire8 domire8 deleted the feature/ws-control-only branch December 4, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future of base image
3 participants