Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast internal/allow/block networks to all Hogs #30

Merged
merged 2 commits into from
May 25, 2023

Conversation

syncpark
Copy link
Contributor

@syncpark syncpark commented May 23, 2023

  • Add function to broadcast internal/allow/block networks to all Hogs
  • internal networks is the networks of customer assigned to review node
    • When a new node with review is inserted, the customer networks of the node is broadcasted.
    • When the customer of review node is changed, the networks of new customer is broadcasted.
    • When the customer networks of review node is changed, the changed networks is broadcasted.
    • internal networks includes all of the Intranet, Extranet, Gateway addresses of customer.

The networks are defined as following:

struct HostNetworkGroup {
    hosts: Vec<IpAddr>,
    networks: Vec<IpNet>,
    ip_ranges: Vec<RangeInclusive<IpAddr>>,
}

@syncpark syncpark force-pushed the broadcast-allow-and-block-list-to-hog branch from 4bfcdaa to e471712 Compare May 23, 2023 07:42
@syncpark syncpark changed the title Broadcast internal/allow/block networks to all Hogs [WIP] Broadcast internal/allow/block networks to all Hogs May 23, 2023
@syncpark syncpark force-pushed the broadcast-allow-and-block-list-to-hog branch from e471712 to e26872a Compare May 25, 2023 02:35
@syncpark syncpark force-pushed the broadcast-allow-and-block-list-to-hog branch from e26872a to 3f8dd5a Compare May 25, 2023 04:26
@syncpark syncpark changed the title [WIP] Broadcast internal/allow/block networks to all Hogs Broadcast internal/allow/block networks to all Hogs May 25, 2023
pub use self::cert::ParsedCertificate;
pub use self::node::get_node_settings;
pub use self::customer::get_customer_networks;
pub use self::node::{get_customer_id_of_review_host, get_node_settings};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새로 public API에 추가된 함수들도 CHANGELOG에 기록해주세요.

@msk msk enabled auto-merge (rebase) May 25, 2023 18:27
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 51.05% and project coverage change: -0.44 ⚠️

Comparison is base (c30f351) 55.20% compared to head (4381117) 54.76%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   55.20%   54.76%   -0.44%     
==========================================
  Files          45       45              
  Lines        8275     8454     +179     
==========================================
+ Hits         4568     4630      +62     
- Misses       3707     3824     +117     
Impacted Files Coverage Δ
src/graphql/allow_network.rs 83.96% <0.00%> (-9.03%) ⬇️
src/graphql/block_network.rs 83.96% <0.00%> (-9.03%) ⬇️
src/graphql/node.rs 86.02% <ø> (ø)
src/graphql.rs 43.72% <27.27%> (-1.33%) ⬇️
src/graphql/customer.rs 58.96% <55.20%> (-2.99%) ⬇️
src/graphql/node/crud.rs 57.92% <71.66%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@msk msk merged commit a5b4c4d into main May 25, 2023
@msk msk deleted the broadcast-allow-and-block-list-to-hog branch May 25, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants