Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Directly import babel plugins #533

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

AbhiPrasad
Copy link
Contributor

fixes #532

Instead of relying on the string path for the plugin let's import the babel plugin directly. This should hopefully be more robust.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 6:10pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 6:10pm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5882326815

  • 2 of 12 (16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 26.698%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/compiler/plugin.ts 2 12 16.67%
Totals Coverage Status
Change from base Build 5863743632: 0.02%
Covered Lines: 1268
Relevant Lines: 4931

💛 - Coveralls

@AbhiPrasad
Copy link
Contributor Author

@aidenybai any appetite to get this merged in? Or do we want to explore an alternate approach?

@tobySolutions
Copy link
Contributor

@aidenybai any appetite to get this merged in? Or do we want to explore an alternate approach?

I'll have @aidenybai look at it. Thanks @AbhiPrasad!

@aidenybai
Copy link
Owner

@AbhiPrasad this is probably a lot smarter

@aidenybai aidenybai merged commit 0e6077f into aidenybai:main Aug 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants