Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Remix To Vite section of docs #838

Merged
merged 1 commit into from Nov 18, 2023

Conversation

tobySolutions
Copy link
Contributor

@tobySolutions tobySolutions commented Nov 18, 2023

I added Remix to the Vite compiler section of the docs, resolves #837

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

I added Remix to the Vite compiler section of the docs
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6913200366

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 25.706%

Totals Coverage Status
Change from base Build 6902381524: 0.0%
Covered Lines: 1257
Relevant Lines: 5082

💛 - Coveralls

Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2023 9:51am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2023 9:51am

@tobySolutions
Copy link
Contributor Author

This change is subject to review from @aidenybai, but, I'll merge this for now

@tobySolutions tobySolutions merged commit 579a625 into main Nov 18, 2023
8 checks passed
Aslemammad pushed a commit that referenced this pull request Jan 2, 2024
I added Remix to the Vite compiler section of the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Add Remix configuration to documentation.
2 participants