Small fixes for 0.1.0 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomezzz
added
documentation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This was referenced Jan 30, 2023
Merged
johanos1
approved these changes
Feb 1, 2023
GabrieleMeoni
requested changes
Feb 2, 2023
There was a problem hiding this comment.
The notebook is working fine for me now. Could you, please, remove this old statement from the notebook: "
N.B. Notice that, when sim.perform_activity(...) is called, the keyword await is needed only for Jupyter notebooks to ensure the correct management of asynchronous functions. Remove it otherwise. " and update it with something to explain why we use the new function wait_for_activity?
GabrieleMeoni
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
paseos_instance.wait_for_activity()to allow waiting for activities to finish.Resolved Issues
How Has This Been Tested?
CI, notebook
Related Pull Requests
N/A