Further steps for release v0.1.0 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomezzz
added
documentation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
GabrieleMeoni
requested changes
Feb 2, 2023
paseos/actors/actor_builder.py
Outdated
| logger.warning( | ||
| "The actor already had a power device. Currently only one device is supported. Overriding old device." | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please, add a statement about to the README where you explain that it is possible to add only power device at the time. Trying to add more than one will lead to override the first.
paseos/actors/actor_builder.py
Outdated
| @@ -211,6 +217,12 @@ def set_thermal_model( | |||
| actor, SpacecraftActor | |||
| ), "Thermal models are only supported for SpacecraftActors" | |||
|
|
|||
| # Check if the actor already had a thermal model | |||
| if actor.has_thermal_model: | |||
There was a problem hiding this comment.
As above. If you want, you can also make one statement for all the models somewhere.
README.md
Outdated
|
|
||
| ``` | ||
|
|
||
| This requires `Python 3.8` due to [pykep's limited support of pip](https://esa.github.io/pykep/installation.html). If you encounter problems, please consider setting up a `conda` environment to install dependencies. |
There was a problem hiding this comment.
Suggested change
| This requires `Python 3.8` due to [pykep's limited support of pip](https://esa.github.io/pykep/installation.html). If you encounter problems, please consider setting up a `conda` environment to install dependencies. | |
| This requires `Python 3.8` due to [pykep's limited support of pip](https://esa.github.io/pykep/installation.html). If you encounter problems, please consider setting up a dedicated `conda` environment to install dependencies. |
README.md
Outdated
| @@ -483,6 +498,16 @@ sim.register_activity( | |||
| sim.perform_activity("activity_A") | |||
| ``` | |||
|
|
|||
| ##### Waiting for Activities to Finish | |||
|
|
|||
| If you want to run multiple activities in a row or just wait for the existing one to finish, you can use | |||
There was a problem hiding this comment.
Suggested change
| If you want to run multiple activities in a row or just wait for the existing one to finish, you can use | |
| At the moment, parallel running of multiple activities is not supported. | |
| However, if you want to run multiple activities in a row or just wait for the existing one to finish, you can use |
GabrieleMeoni
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building on #116 , merge that first
Resolved Issues
Already working on some things for #119 until currently open PRs are merged.
How Has This Been Tested?
Will be tested in #119
Related Pull Requests