Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using TLEs #175

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Allow using TLEs #175

merged 4 commits into from
Jul 14, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jul 7, 2023

Description

Summary of changes

  • Provide option to create actors from two-line elements which also implicitly allows using SGP4
  • Added a tests
  • Added docs for it
  • Minor refactoring in ActorBuilder

Resolved Issues

How Has This Been Tested?

CI/CD

Related Pull Requests

N/A

@gomezzz gomezzz added enhancement New feature or request feature implementing a new feature user-facing Anything that users can interact with physical-model All things involving some physical models labels Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Overall Coverage

Coverage Report
FileStmtsMissCoverMissing
paseos
   __init__.py31294%44, 47
   paseos.py1511491%73–74, 151–152, 209, 224, 242, 251, 269, 300, 308–311, 411–412
paseos/activities
   activity_manager.py43393%46, 74, 157
   activity_processor.py58198%121
   activity_runner.py621084%80–84, 104–113, 122–125
paseos/actors
   actor_builder.py1262481%20–26, 29, 109–111, 158–167, 301, 358, 386, 398–402, 409–410, 417–418
   base_actor.py1201885%82, 99, 115, 153, 193–195, 224, 233, 250, 273, 279–282, 286, 300, 348
   ground_station_actor.py15380%47–53
   spacecraft_actor.py61198%123
paseos/communication
   get_communication_window.py22291%38, 63
   is_in_line_of_sight.py741580%66, 73, 81, 140–157, 199, 219
paseos/power
   charge_model.py17194%52
   discharge_model.py7271%22, 34
   is_in_eclipse.py39490%28–29, 86–87
paseos/tests
   activity_test.py57395%90, 93–94
   communication_window_test.py58198%193
   eclipse_test.py11191%22
   import_test.py6183%13
   init_test.py8188%16
   line_of_sight_test.py65494%147–150
   thermal_model_test.py30197%61
   visualization_test.py20195%31
paseos/utils
   check_cfg.py611870%31, 40, 46, 60–62, 67, 70–72, 75–77, 80–82, 98, 103
   operations_monitor.py71494%86, 127–130
paseos/visualization
   animation.py18667%27–30, 35, 44
   plot.py9367%28–31
   space_animation.py1952090%132, 156, 159–162, 168, 278, 301–303, 308, 318–319, 323, 358, 364–365, 396, 410–421
TOTAL187516491% 

Tests Skipped Failures Errors Time
31 0 💤 0 ❌ 0 🔥 1m 3s ⏱️

Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it worked. README is clear.

Should we, maybe, add one line to Sentinel-2 example on how you can import TLEs by using the dedicated function? Because, at the moment we do all the process to estimate the ephemerides from the TLEs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gomezzz gomezzz mentioned this pull request Jul 11, 2023
1 task
@gomezzz gomezzz merged commit 2d0714c into main Jul 14, 2023
3 checks passed
@gomezzz gomezzz deleted the allow_using_TLE branch July 14, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature implementing a new feature physical-model All things involving some physical models user-facing Anything that users can interact with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow creating spacecraft actors from TLEs
2 participants