Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing custom propagators #177

Merged
merged 15 commits into from
Jul 14, 2023
Merged

Allowing custom propagators #177

merged 15 commits into from
Jul 14, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jul 11, 2023

Description

Summary of changes

  • Added ability to define custom functions to determine actor position and velocity
  • Added notebook showcasing how to integrate orekit
  • Added readme example
  • New tests
  • Some formatting

Resolved Issues

How Has This Been Tested?

CI /CD , new notebook

Related Pull Requests

@gomezzz gomezzz added enhancement New feature or request example An example to showcase something feature implementing a new feature user-facing Anything that users can interact with physical-model All things involving some physical models labels Jul 11, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Overall Coverage

Coverage Report
FileStmtsMissCoverMissing
paseos
   __init__.py31294%44, 47
   paseos.py1511491%73–74, 151–152, 209, 224, 242, 251, 269, 300, 308–311, 411–412
paseos/activities
   activity_manager.py43393%46, 74, 157
   activity_processor.py58198%121
   activity_runner.py621084%80–84, 104–113, 122–125
paseos/actors
   actor_builder.py1452781%21–27, 30, 119–121, 148–150, 197–206, 340, 397, 425, 437–441, 448–449, 456–457
   base_actor.py1251886%85, 102, 118, 156, 196–198, 227, 236, 253, 274, 280–283, 289, 304, 359
   ground_station_actor.py15380%47–53
   spacecraft_actor.py61198%123
paseos/communication
   get_communication_window.py22291%38, 63
   is_in_line_of_sight.py741580%66, 73, 81, 140–157, 199, 219
paseos/power
   charge_model.py17194%52
   discharge_model.py7271%22, 34
   is_in_eclipse.py39490%28–29, 86–87
paseos/tests
   activity_test.py57395%90, 93–94
   communication_window_test.py58198%193
   eclipse_test.py11191%22
   import_test.py6183%13
   init_test.py8188%16
   line_of_sight_test.py65494%147–150
   thermal_model_test.py30197%61
   visualization_test.py20195%31
paseos/utils
   check_cfg.py611870%31, 40, 46, 60–62, 67, 70–72, 75–77, 80–82, 98, 103
   operations_monitor.py71494%86, 127–130
paseos/visualization
   animation.py18667%27–30, 35, 44
   plot.py9367%28–31
   space_animation.py1952090%132, 156, 159–162, 168, 278, 301–303, 308, 318–319, 323, 358, 364–365, 396, 410–421
TOTAL192416791% 

Tests Skipped Failures Errors Time
32 0 💤 0 ❌ 0 🔥 56.611s ⏱️

@@ -0,0 +1,256 @@
{
Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example requires an orekit installation via conda.

This examples requires an orekit installation via conda. To be used successfully, JAVA shall be installed.

Additional you will need to place the orekit data as orekit-data.zip in the same folder as this notebook.

Additional you will need to place the orekit data as orekit-data.zip in the same folder as this notebook. N.B. The zip shall be not decompressed.


Reply via ReviewNB

@@ -0,0 +1,256 @@
{
Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everything went well, you should see the same plot again, except this time it's happening inside PASEOS. :)

If everything went well, you should see the same plot again, except this time it's happening inside PASEOS :).


Reply via ReviewNB

Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comments in the notebook, can you, please, add some information about the scenario in orekit_propagator.py (e.g., satellite mass, type of orbit, etc)

@gomezzz gomezzz merged commit 74baf61 into main Jul 14, 2023
3 checks passed
@gomezzz gomezzz deleted the allowing_custom_propagators branch July 14, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request example An example to showcase something feature implementing a new feature physical-model All things involving some physical models user-facing Anything that users can interact with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate orekit
2 participants