Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create communication handler #22

Merged
merged 25 commits into from
Oct 20, 2022
Merged

Create communication handler #22

merged 25 commits into from
Oct 20, 2022

Conversation

GabrieleMeoni
Copy link
Collaborator

Description

Summary of changes

How Has This Been Tested?

  • Check related test (two satellites starting from the same point and moving along diverging orbits. The communication link is tested at t=0 and after the end of the communication window).

gomezzz and others added 13 commits October 11, 2022 13:15
@GabrieleMeoni GabrieleMeoni added the feature implementing a new feature label Oct 19, 2022
gomezzz
gomezzz requested changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

paseos/actors/base_actor.py Show resolved Hide resolved
paseos/actors/base_actor.py Outdated Show resolved Hide resolved
paseos/actors/base_actor.py Outdated Show resolved Hide resolved
paseos/actors/base_actor.py Outdated Show resolved Hide resolved
paseos/actors/base_actor.py Outdated Show resolved Hide resolved
paseos/communication/check_communication_link.py Outdated Show resolved Hide resolved
paseos/communication/check_communication_link.py Outdated Show resolved Hide resolved
paseos/tests/check_communication_test.py Outdated Show resolved Hide resolved
paseos/tests/check_communication_test.py Outdated Show resolved Hide resolved
paseos/tests/check_communication_test.py Outdated Show resolved Hide resolved
gomezzz and others added 3 commits October 19, 2022 17:33
@gomezzz
Changed unit description for consistency
0277e1d
Changed name for "check_communication_link" to
ce5cae1 
"get_communication_window". Changed return and input times. Added checks
and improved names for inputs and local variables.
Merge branch 'Power/Battery-Modeling' into create_communication_handler
7a4c546
@gomezzz gomezzz self-requested a review October 19, 2022 17:10
gomezzz
gomezzz approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change still open in docstring, but ready otherwise, please wait with merging for #10 🙏

paseos/actors/base_actor.py Outdated Show resolved Hide resolved
@GabrieleMeoni GabrieleMeoni merged commit 85fe34e into main Oct 20, 2022
@GabrieleMeoni GabrieleMeoni deleted the create_communication_handler branch October 20, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

@johanos1 johanos1 Awaiting requested review from johanos1

Assignees
No one assigned
Labels
feature implementing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GabrieleMeoni @gomezzz