Create actor factory #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gomezzz
added
tests
johanos1
requested changes
Oct 22, 2022
paseos/actors/base_actor.py
Outdated
|
|
||
| self._communication_devices = DotMap(_dynamic=False) | ||
|
|
||
| def get_local_time(self) -> pk.epoch: |
There was a problem hiding this comment.
Is it not more natural to use getters? See this conversation in Stackoverflow: https://stackoverflow.com/questions/2627002/whats-the-pythonic-way-to-use-getters-and-setters#:~:text=%2B500-,What%27s%20the%20pythonic%20way%20to%20use%20getters%20and%20setters%3F,-The%20%22Pythonic%22%20way
There was a problem hiding this comment.
changed everywhere :) forgot about this feature, thanks for pointing out!
johanos1
reviewed
Oct 24, 2022
| self._known_actors = {} | ||
|
|
||
| def remove_known_actor(self, actor_name: str): |
There was a problem hiding this comment.
Right now we are only distinguishing actors based on their names. I think it would make sense to make this a bit more general and use the a hash of the static features in the actors. I will write an issue for this.
johanos1
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Resolved Issues
How Has This Been Tested?
With updated tests.
Related Pull Requests
N/A