Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow other entities than PASEOS to use event loop #48 #50

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Allow other entities than PASEOS to use event loop #48 #50

merged 3 commits into from
Nov 28, 2022

Conversation

johanos1
Copy link
Collaborator

@johanos1 johanos1 commented Nov 25, 2022 •
edited
Loading

Description

Summary of changes

  • activities are added to the event loop instead of starting the event loop every time
  • tests are updated

Resolved Issues

How Has This Been Tested?

  • Unit tests have been updated
  • PASEOS was pip installed into other module and tested therein

Related Pull Requests

gomezzz
gomezzz approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (see also comments in #51 )

@johanos1 johanos1 merged commit 16191c4 into main Nov 28, 2022
@johanos1 johanos1 deleted the PR48 branch November 28, 2022 19:02
@johanos1 johanos1 restored the PR48 branch November 28, 2022 19:02
@gomezzz gomezzz deleted the PR48 branch December 1, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomezzz gomezzz gomezzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow other entities than PASEOS to use event loop
2 participants
@johanos1 @gomezzz