Import psutil conditionally; install it only in Linux platforms #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good Guillem 👍
…On Wed, 12 May 2021, 00:07 Guillem Francès, ***@***.***> wrote:
See #99 <#99> for the rationale to
this PR
------------------------------
You can view, comment on, or merge this pull request online at:
#103
Commit Summary
- Import psutil conditionally; install it only in Linux platforms
File Changes
- *M* setup.py
<https://github.com/aig-upf/tarski/pull/103/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7>
(5)
- *M* src/tarski/utils/resources.py
<https://github.com/aig-upf/tarski/pull/103/files#diff-22198bbba4b1fba50275e6c7a69d7e42bec82a5a83a8ee0d6a0ab7d17a53f5d6>
(25)
- *A* tests/test_utils.py
<https://github.com/aig-upf/tarski/pull/103/files#diff-33c13e0b177bacd2f02e29bcb8aea5b49e7ce34901fd8f41fefb65defba1bd33>
(13)
Patch Links:
- https://github.com/aig-upf/tarski/pull/103.patch
- https://github.com/aig-upf/tarski/pull/103.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#103>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMQKJONQX2KH3YEALAWQTTNE23TANCNFSM44VTMB2Q>
.
|
|
It fail some checks? |
|
Yes, but they seem related to some code in a previous commit by @miquelramirez (easy to see the first failing commit here). |
|
Cheers for the heads up, it's a trivial issue, will fix soon.
…On Wed, 12 May 2021, 16:25 Guillem Francès, ***@***.***> wrote:
Yes, but they seem related to some code in a previous commit by
@miquelramirez <https://github.com/miquelramirez> (easy to see the first
failing commit here <https://github.com/aig-upf/tarski/commits/devel>).
@miquelramirez <https://github.com/miquelramirez> , do you think this is
fixable? Or maybe I could move the NDL-related commits to a diff branch
(they seem pretty self-contained, but I've only given a quick glance)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#103 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADMQKOISWZWLR2T2YSLSOLTNINNJANCNFSM44VTMB2Q>
.
|
|
Should be fixed with commit b4be590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #99 for the rationale to this PR