Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/exclude option for source files with glob pattern #95

Open
ktsn opened this issue Nov 9, 2016 · 4 comments
Open

include/exclude option for source files with glob pattern #95

ktsn opened this issue Nov 9, 2016 · 4 comments

Comments

@ktsn
Copy link

ktsn commented Nov 9, 2016

Hello, thank you for your great tool. I feel really comfortable to use it.

I think it would be very nice if we can specify glob pattern for source files in order to handle complex directory structures. Also exclude option would be useful.

Maybe for example:

source_include:
  - src/**/*.scss
source_exclude:
  - src/sub_project/**

How would you feel about this?

@nakajmg
Copy link
Contributor

nakajmg commented Nov 14, 2016

Hello, thank you for good idea!

I think it would be very nice if we can specify glob pattern for source files in order to handle complex directory structures. Also exclude option would be useful.

I agree with you 👍

However that example is included breaking change.
I think source and source_exclude are better way:

source:    
    - src/**/*.scss
source_exclude:                    
    - src/sub_project/**

also make source_include an alias for source optionally.

I'll planning implement source_exclude options on next update 👍

@ktsn
Copy link
Author

ktsn commented Nov 14, 2016

Hi, @nakajmg. Thanks for your reply!

My intention for source_include is to avoid breaking change of the source option's behavior. If the source accepts glob pattern, we cannot just specify directory name for it.

Let me summarize my suggestion:

  • source -> no changes, expects directory names
  • source_include -> expects glob patterns, matched files are added as source.
  • source_exclude -> expects glob patterns, matched files are removed from source.

@nakajmg
Copy link
Contributor

nakajmg commented Nov 16, 2016

Thank you for the summary!! I got it 👍
source_include and source_exclude options are so nice.

We will planning to implement source_include and source_exclude options on next update 💁

(also We will planning to use globby instead of node-glob inside Aigis.
If you have other good ideas, Please tell us.)

@ktsn
Copy link
Author

ktsn commented Nov 16, 2016

Thanks! I'm looking forward to the next version 🙂
globby looks pretty good 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants